After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 590447 - [flvmux] crashes when writing index with <= 128 entries
[flvmux] crashes when writing index with <= 128 entries
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 0.10.16
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-08-01 11:28 UTC by Tim-Philipp Müller
Modified: 2009-08-03 18:10 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Tim-Philipp Müller 2009-08-01 11:28:44 UTC 
Run

 -good/tests/check $ make elements/flvmux.valgrind

Crashes and/or shows invalid memory access in valgrind. Also other weird failures, presumably re-use related.

 gst-launch-0.10 audiotestsrc num-buffers=2 ! flvmux ! fakesink

will reproduce this in gst-launch.
Comment 1 Sebastian Dröge (slomo) 2009-08-03 18:10:11 UTC 
commit a931c6759771a3942239c19cadeee3726508595d
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Mon Aug 3 20:08:33 2009 +0200

    flvmux: Fix unit test to correctly handle request pads
    
    Request pads are removed by the element instance in PAUSED->READY
    so we need to re-request pads for every run and link them again.
    
    Last fix for bug #590447.

commit 8b9d547c146cacab2e9eb713b167c295661fd3cf
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Mon Aug 3 20:08:00 2009 +0200

    flvmux: Fix writing of the index for < 128 buffers
    
    Partially fixes bug #590447.

commit cb4eb5714c7a3bb0b5caf4a57937c5e4e4e4018f
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Mon Aug 3 20:07:00 2009 +0200

    flvmux: Fix resetting of the element
    
    Reset the have_video/have_audio flags and make sure to
    properly release the request pads.
    
    Partially fixes bug #590447.