After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 590401 - GstPulseSrc's pulse probe is not initialized correctly
GstPulseSrc's pulse probe is not initialized correctly
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal trivial
: 0.10.16
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-07-31 19:07 UTC by Jonathan Tellier
Modified: 2009-08-03 11:38 UTC
See Also:
GNOME target: ---
GNOME version: 2.25/2.26

Attachments
Here's a suggested patch (649 bytes, patch)
2009-07-31 19:08 UTC, Jonathan Tellier 		committed Details | Review

Description Jonathan Tellier 2009-07-31 19:07:10 UTC 
Hello,

I'm pretty new in gstreamer development, so maybe what I've seen as an error is actually intentional. I've asked on IRC, but could not get an answer.

So anyway, in gst_pulsesrc_init(), when "pulsesrc->probe" is initialized, "pulsesrc->device" is passed to gst_pulseprobe_new() as the server string. This does not make a difference since both should be NULL, but it seemed odd to me.
Comment 1 Jonathan Tellier 2009-07-31 19:08:35 UTC 
Created attachment 139644 [details] [review]
Here's a suggested patch
Comment 2 Wim Taymans 2009-08-03 11:38:10 UTC 
commit dbf4d8a9109c1ecdfbfa1e7280bdead64b121061
Author: Jonathan Tellier <jonathan.tellier at gmail.com>
Date:   Mon Aug 3 13:32:12 2009 +0200

    pulsesrc: initialize the probe with the server
    
    When creating a new probe, pass the server instead of the device string.
    
    fixes #590401