After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 590172 - ffdec_theora does not work
ffdec_theora does not work
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-libav
git master
Other Linux
: Normal normal
: 0.10.9
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-07-29 18:02 UTC by Olivier Crête
Modified: 2009-07-29 18:53 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Olivier Crête 2009-07-29 18:02:50 UTC
"videotestsrc ! theoraenc ! ffdec_theora ! xvimagesink" fails.
"videotestsrc ! theoraenc ! rtptheorapay ! rtptheoradepay ! ffdec_theora ! xvimagesink" fails too.

This tries to use the internal theora decoder of ffmpeg (not libtheora). 

Thats probably a problem with gst-ffmpeg... Anyway, I suggest just disabling the ffmpeg implementation and going with the libtheora implementation for now.

Proposed patch:

diff --git a/ext/ffmpeg/gstffmpegdec.c b/ext/ffmpeg/gstffmpegdec.c
index 6eb0903..35c2330 100644
--- a/ext/ffmpeg/gstffmpegdec.c
+++ b/ext/ffmpeg/gstffmpegdec.c
@@ -2747,6 +2747,7 @@ gst_ffmpegdec_register (GstPlugin * plugin)
     /* MPEG1VIDEO : the mpeg2video decoder is preferred */
     /* MP1 : Use MP3 for decoding */
     /* MP2 : Use MP3 for decoding */
+    /* Theora: Use libtheora based theoradec */
     if (!strcmp (in_plugin->name, "gif") ||
         !strcmp (in_plugin->name, "vorbis") ||
         !strcmp (in_plugin->name, "mpeg1video") ||
@@ -2754,6 +2755,7 @@ gst_ffmpegdec_register (GstPlugin * plugin)
         !strcmp (in_plugin->name, "mp1") ||
         !strcmp (in_plugin->name, "mp2") ||
         !strcmp (in_plugin->name, "libfaad") ||
+        !strcmp (in_plugin->name, "theora") ||
         !strcmp (in_plugin->name, "mpeg4aac")) {
       GST_LOG ("Ignoring decoder %s", in_plugin->name);
       goto next;
Comment 1 Olivier Crête 2009-07-29 18:53:06 UTC
commit 597f32e89515455761fbc209db7e2faf2ea43542
Author: Olivier Crête <olivier.crete@collabora.co.uk>
Date:   Wed Jul 29 14:49:56 2009 -0400

    ffmpegdec: Disable theora decoder
    
    The wrapper does not give the decoder the extradata correctly.
    Just use theoradec.
    
    Fixes bug #590172