GNOME Bugzilla – Bug 590146
adder regressions
Last modified: 2009-08-31 20:07:25 UTC
Three things: 1.) Also use the capsfilter if there is no src-peer as the caps constrain what we can do 2.) Don't create any_caps as a default, as we check for NULL to skip the filtering. This is a (small) performance regression as we always intersect. 3.) Reset newly introduced flush_stop_pending in state_changed. I can split the changes, if wanted.
Created attachment 139479 [details] [review] 3 fixes
The third part (resetting flush_stop_pending) is 100% ok with me. I still need to grasp the other changes though (never used the caps property of adder).
commit 7205bbc0315eb0e76cd83e38132efbaae80af60c Author: Stefan Kost <ensonic@users.sf.net> Date: Thu Jul 30 13:42:21 2009 +0300 adder: reset pending flush-stop flag in state_changed. (mostly) Fixes #590146. I'll commit the rest after the release.
commit e7368354d514117c05636fca816966caba5ce0ed Author: Stefan Kost <ensonic@users.sf.net> Date: Mon Aug 31 22:48:01 2009 +0300 adder: improve caps filter functionality. Fixes #590146. Also use the capsfilter if there is no src-peer as the caps constrain what we can do. Don't create any_caps as a default, as we check for NULL to skip the filtering. This is a (small) performance regression as we always intersect otherwise.