GNOME Bugzilla – Bug 590137
Vinagre Handle tube crashs if VNC plugin is not enable
Last modified: 2009-07-30 12:24:09 UTC
Steps to reproduce: Share your desktop with an Empathy contact and disable VNC plugin in vinagre. Stack trace: Bug fixed Other information: http://git.collabora.co.uk/?p=user/ksz/vinagre.git;a=shortlog;h=refs/heads/fix-bug-vnc-plugin
Hi, Arnaud. Some points: - Use vinagre_utils_show_error() where is possible. Printing errors in terminal is not very useful. - Make all strings translatable. As above, I see lots of error messages not translated. - It's better to explicitly add the protocol to the host string, something like "vnc://hostname_or_ip_address", so that vinagre_connection_new_from_string() can work correctly in the future, with other tube protocols.
Ok I fixed all your comments. What do you think about this : http://git.collabora.co.uk/?p=user/ksz/vinagre.git;a=shortlog;h=refs/heads/fix-bug-vnc-plugin As regards,
- Debug messages do not need to be translated IMO. They will only be used by developers that want to debug some stuff. And developers read English :) - There's still some strings not translated, for instance "No error given". - About the inclusion of the protocol in the hostname: Ideally it should be done on the other side of the tube. In the future Empathy (or other software) could use the tube feature with other protocol than VNC (ssh, rdp, nx, etc). So, vinagre code will be ready for that. So, I'd prefer that this protocol came from the 'server' tube. If the protocol is not found in hostname, vinagre_connection_new_from_string () falls back to vnc anyway. Any doubts, ping me on IRC ;)
Branch merged.