After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 590030 - rtpsource: Incoming buffers do not always have caps
rtpsource: Incoming buffers do not always have caps
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 0.10.14
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-07-28 16:03 UTC by Olivier Crête
Modified: 2009-07-28 16:21 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
rtpsource: Incoming buffers do not always have caps (876 bytes, patch)
2009-07-28 16:03 UTC, Olivier Crête
committed Details | Review

Description Olivier Crête 2009-07-28 16:03:03 UTC
The rtp_source_update_caps() function may assert when it tries to read from
the non-existent caps. 

That said, in the case I'm looking at, the caps shoudl always have been NULL,
so I'm curious to see why the src had non-NULL caps in there..
Comment 1 Olivier Crête 2009-07-28 16:03:25 UTC
Created attachment 139395 [details] [review]
rtpsource: Incoming buffers do not always have caps
Comment 2 Wim Taymans 2009-07-28 16:21:17 UTC
commit 9232e2278c229a0d238c4a22b0169b3024cb7914
Author: Wim Taymans <wim.taymans@collabora.co.uk>
Date:   Tue Jul 28 18:18:20 2009 +0200

    rtpsource: allow for NULL caps on buffers
    
    Add the NULL caps check where it matters and also cover another case of
    potential NULL caps.
    
    Fixes #590030

commit 03348629cea29e878c9acd2f5aa344fa71b009b0
Author: Olivier Crête <olivier.crete@collabora.co.uk>
Date:   Tue Jul 28 11:59:56 2009 -0400

    rtpsource: Incoming buffers do not always have caps