Bug 589915 – gedit crashed with SIGSEGV in strlen()

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 589915 - gedit crashed with SIGSEGV in strlen()


Summary:	gedit crashed with SIGSEGV in strlen()


Status:	RESOLVED FIXED

Product:	gvfs
Classification:	Core
Component:	general
Version:	unspecified
Hardware:	Other Linux

Importance:	Normal critical
Target Milestone:	---
Assigned To:	gvfs-maint
QA Contact:	gvfs-maint

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2009-07-27 18:19 UTC by Pedro Villavicencio
Modified:	2009-08-04 09:16 UTC

See Also:
GNOME target:	---
GNOME version:	2.27/2.28

Attachments
Fix gvfs bug which causes gedit to crash when saving a file (1.05 KB, patch) 2009-08-04 07:42 UTC, Peter Waller	none	Details \| Review

Description Pedro Villavicencio 2009-07-27 18:19:12 UTC

this report has been filed here:

https://bugs.edge.launchpad.net/ubuntu/+source/gedit/+bug/404490

"happens after I open any file on sftp and save.
it crashes immediately after saving the file"

".

+ Trace 216650

Thread 1 (process 5948)

#0 strlen
at ../sysdeps/x86_64/strlen.S line 37
#1 IA__g_strdup
at /build/buildd/glib2.0-2.21.4/glib/gstrfuncs.c line 101
#2 IA__g_error_copy
at /build/buildd/glib2.0-2.21.4/glib/gerror.c line 162
#3 IA__g_simple_async_result_set_from_error
at /build/buildd/glib2.0-2.21.4/gio/gsimpleasyncresult.c line 496
#4 async_close_done
at gdaemonfileoutputstream.c line 1516
#5 async_iterator_done
at gdaemonfileoutputstream.c line 1206
#6 async_op_handle
at gdaemonfileoutputstream.c line 1257
#7 async_read_op_callback
at gdaemonfileoutputstream.c line 1271
#8 async_ready_callback_wrapper
at /build/buildd/glib2.0-2.21.4/gio/ginputstream.c line 477
#9 read_async_cb
at /build/buildd/glib2.0-2.21.4/gio/gunixinputstream.c line 476
#10 IA__g_main_context_dispatch
at /build/buildd/glib2.0-2.21.4/glib/gmain.c line 1960
#11 g_main_context_iterate
at /build/buildd/glib2.0-2.21.4/glib/gmain.c line 2591
#12 IA__g_main_loop_run
at /build/buildd/glib2.0-2.21.4/glib/gmain.c line 2799
#13 IA__gtk_main
at /build/buildd/gtk+2.0-2.17.5/gtk/gtkmain.c line 1205
#14 main
at gedit.c line 724

Comment 1 Peter Waller 2009-08-02 11:35:30 UTC

I have also seen this bug.

Gentoo x86_64

gedit 2.26.2
gvfs 1.3.3
dbus 1.2.12

Comment 2 Peter Waller 2009-08-04 07:42:01 UTC

It appears that gvfs cast async_close_done to a AsyncIteratorDone type in gdaemonfileoutputstream.c in the function g_daemon_file_output_stream_close_async. This masked a bug where the function pointer type AsyncIteratorDone was changed but the function arguments for async_close_done were not.

I attach a patch which fixes the crash for me.

Comment 3 Peter Waller 2009-08-04 07:42:57 UTC

Created attachment 139842 [details] [review]
Fix gvfs bug which causes gedit to crash when saving a file

Comment 4 Paolo Borelli 2009-08-04 07:49:16 UTC

Thanks for the patch! Reassigning to gvfs then

Comment 5 Benjamin Otte (Company) 2009-08-04 09:16:29 UTC

Thx. I applied the patch.