GNOME Bugzilla – Bug 589829
Videos Synced to Wrong Folder on Android with Patch
Last modified: 2009-07-30 00:15:34 UTC
On Android devices, videos are synced to the Music/ folder instead of the Videos/ folder which causes organizational problems and problems with some Android apps. This patch allows the syncing of videos on mass storage devices to a different folder than the music folder. On Android, it syncs to the Video/ directory instead of Music/ (This is where Videos are searched for on Android. For other devices, by default it syncs videos to the AudioFolder/Videos.
Created attachment 139263 [details] [review] Patch to sync videos to correct directory in Android
Thanks for the patch ! A few nitpicks comments : 1/ There's a whitespace change in docs/Banshee/en/Banshee.Hardware/IDeviceMediaCapabilities.xml, which is certainly unneeded. 2/ The patch adds some commented out code in MassStorageSource.cs (//file_path...), please remove it 3/ Please indent with spaces. I've seen some tabs in the last lines Sadly, I can't really test this : my mass storage device doesn't do proper videos, and I don't have an Android device :(
Created attachment 139313 [details] [review] Cleaned Up Patch For Video Directory Thanks for comments. I cleaned up the patch addressing your issues.
Created attachment 139397 [details] [review] Addditional Patch for WebOS Videos/ Directory - Should be used after applying the above patch for Android. Additional Patch for WebOS Videos/ Directory - Should be used after applying the above patch for Android. After discussion with Jeff Wheeler, it was determined WebOS also has a separate folder for Video.
For further evidence that this should be accepted. I just tested it on my rockbox ipod (with no special video folder) and it worked fine. Videos were synced to Music/Videos/Album as expected.
Created attachment 139421 [details] [review] Complete Patch Encompassing all Previous Versions Added a new complete patch containing everything in prevous patches plus suggestions. Also includes ability to read video_folders from .is_audio_player file. This should be final version.
Thanks Jack, committed.