GNOME Bugzilla – Bug 589820
[keyframes] audio volume curves don't allow amplifying the volume
Last modified: 2009-08-12 06:30:39 UTC
The current implementation of keyframe curves for audio sets 100% = the height of the clip. I'm guessing that it could be better to have 100% volume = 50% of the height of the clip, so if you want to make it 2x louder, you raise it to the top of the clip (200% volume). But then I'm not sure, perhaps this "amplification" thing is something that doesn't belong in curves, but in a clip's properties pane (to be able to set arbitrary values) or in the layers' volume slider (if there's one).
It would indeed be easier for new user to understand that the curve allows to both decrease AND increase the volume if the curve starts on the middle (and not on top) of the audio track. Anyway, curves must allow to both decrease and increase the volume. Or it would not be efficient nor intuitive
Marking this as a blocker
Pushed branch bug_58920 to my github repository commit 45f391c08de99dee35b0adbeaa64133f2b19fb20 Author: Brandon Lewis <brandon_lewis@berkeley.edu> Date: Mon Jul 27 11:49:19 2009 -0700 track.py: pass along interpolator property overrides when given fixes bug 589820 by allowing volume to be set from 0 - 5. Up to a factor 10 is possible with the volume element, but this makes the scale unusably small with the current clip height.
went ahead and merged this
Isn't it somehow weird that the default (100%) volume is not put at the middle (50%) of the clip height?
Only if you assume the maximum volume is 200% of the original volume. The volume element allows us to go up to 1000% of the original. I decided on a compromise of 500%, but would definitely consider reducing it to 200% for usability's sake.
After a bit of playing with it, I'd say, please go ahead and make it max out at 200%. Reasoning: - It's really strange, visually, to not have the line centered when at the default volume - Less precision when lowering volume - May encourage too much amplification, and then, off-the-peaks sound - Perhaps we could make amplification a separate "audio effect" that would be applied on top, with the nice ability (like audacity) to default to maximum amplification "that does not go above 0 dB" (and a checkbox to bypass that). It may be cleaner that way? I'm currently writing the manual section on this and find it a bit weird to explain otherwise.
Alright, that should be an easy change.