After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 589765 - Clean up GTK+ and Glib non-toplevel includes
Clean up GTK+ and Glib non-toplevel includes
Status: RESOLVED FIXED
Product: balsa
Classification: Other
Component: general
2.3.x
Other Linux
: Normal normal
: ---
Assigned To: Balsa Maintainers
Balsa Maintainers
Depends on:
Blocks: 563413
 
 
Reported: 2009-07-26 14:29 UTC by André Klapper
Modified: 2010-03-24 20:33 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description André Klapper 2009-07-26 14:29:27 UTC 
Balsa uses non toplevel header includes for Glib/Gtk.
These should be removed for GTK3.
See http://live.gnome.org/GnomeGoals/CleanupGTKIncludes
Comment 1 Peter Bloomfield 2009-07-26 17:49:22 UTC 
Hi André:

Thanks for reviewing Balsa!

I tried building with 

make CFLAGS+="-DG_DISABLE_SINGLE_INCLUDES -DGDK_PIXBUF_DISABLE_SINGLE_INCLUDES -DGTK_DISABLE_SINGLE_INCLUDES"

and the only errors were from indirect includes of gtksourceview.h and unique.h.  Balsa does have non toplevel includes:

glib/gi18n.h
glib/gstdio.h
gdk/gdkfont.h
gdk/gdkkeysyms.h

but none of them raises an error with those CFLAGS.  Should we assume they're permitted?

(Actually, including gdk/gdkfont.h seems redundant--will remove it.)

Peter
Comment 2 André Klapper 2009-08-17 18:05:12 UTC 
Hmm... sorry, no idea either. :-/
Comment 3 Miroslav Rajcic 2009-12-14 07:59:39 UTC 
I get the same problems when compiling the another (my own) GtkSourceView dependent project with the CFLAGS suggested for GTK3 compatibility.
My guess is that this bug should be attributed to GtkSourceView package
Comment 4 Peter Bloomfield 2009-12-14 14:35:45 UTC 
GtkSourceView devs are aware of the problem: https://bugzilla.gnome.org/show_bug.cgi?id=563786
Comment 5 Javier Jardón (IRC: jjardon) 2010-03-22 21:34:56 UTC 
I reviewed the balsa code and this bug can be closed as fixed.

I've updated the http://live.gnome.org/GnomeGoals/CleanupGTKIncludes and the Glib/GTK+ documentation with more accurate info about the permitted includes
Comment 6 Peter Bloomfield 2010-03-22 22:06:28 UTC 
(In reply to comment #5)
> I reviewed the balsa code and this bug can be closed as fixed.
> 
> I've updated the http://live.gnome.org/GnomeGoals/CleanupGTKIncludes and the
> Glib/GTK+ documentation with more accurate info about the permitted includes

Thanks for the care and attention!

Balsa still doesn't build with -DGTK_DISABLE_SINGLE_INCLUDES because of GtkSourceView, but I understand that's a problem only until the next release.

On to 3.0!
Comment 7 Javier Jardón (IRC: jjardon) 2010-03-22 22:13:47 UTC 
Hey Peter!

The GtkSourceView problem is already fixed, I've committed some patches some time ago. ( see bug #563786 )

I think you have to wait to the next GtkSourceView release ;)
Comment 8 Pawel Salek 2010-03-24 19:43:43 UTC 
gtkhtml2 has related issues as well...
Comment 9 Peter Bloomfield 2010-03-24 20:33:33 UTC 
(In reply to comment #8)
> gtkhtml2 has related issues as well...

Aargh...

I didn't test that before committing a configure.in patch to add those single-include defines to DEFS.  To handle GtkSourceView, I just put in a test for the upcoming version, but for gtkhtml2...???

Probably best just to leave out -DGDK_PIXBUF_DISABLE_SINGLE_INCLUDES if gtkhtml2 is configured, right?