After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 589574 - [typefind] incorrect sdp file detection
[typefind] incorrect sdp file detection
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
0.10.23
Other Linux
: Normal normal
: 0.10.25
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-07-24 06:52 UTC by Benjamin Gaignard
Modified: 2009-07-29 05:43 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
correction of sdp file detection (528 bytes, patch)
2009-07-24 06:53 UTC, Benjamin Gaignard 		committed Details | Review

Description Benjamin Gaignard 2009-07-24 06:52:16 UTC 
some type some valid sdp file aren't detected as sdp by typefind.
sdp files start by v=0[\r]\n pattern, the test of the pattern is not correctly done in gsttypefindfunctions.c sdp_check_header function.
Comment 1 Benjamin Gaignard 2009-07-24 06:53:02 UTC 
Created attachment 139131 [details] [review]
correction of sdp file detection
Comment 2 Sebastian Dröge (slomo) 2009-07-28 19:48:30 UTC 
What would be examples where the that header check return FALSE although it is "v=0[\r]\n"?

The current check is equivalent to (v=0\r\n) | (v=0\n) and your changes are equivalent to that too unless I'm missing something.
Comment 3 Michael Smith 2009-07-28 20:25:09 UTC 
The current code doesn't work on v=0\r\n (I originally missed why too - try it on an actual test file).

Benjamin's patch is correct; should be landed after the freeze lifts.
Comment 4 Sebastian Dröge (slomo) 2009-07-29 05:43:02 UTC 
Heh, you're right :) I'll push this after freeze then :)

commit 7468f6d7c573168f2c9e745cd1af2e6e38317d86
Author: Benjamin Gaignard <benjamin@gaignard.net>
Date:   Wed Jul 29 07:42:05 2009 +0200

    typefindfunctions: Fix typefinding of SDP files
    
    Fixes bug #589574.