GNOME Bugzilla – Bug 589263
Empathy next tab or previous tab doesnt cycle.
Last modified: 2011-08-29 10:12:28 UTC
When you press "Next Tab" or "Previous Tab" menu items, if you are on the last tab, it goes to the first, and if you are on the first and press previous you go to the last. Other information: All applications work like that, why not empathy too?
Created attachment 138916 [details] [review] Fixes cycling tab bug in chat window
(In reply to comment #0) > All applications work like that, why not empathy too? Epiphany doesn't seem to do that.
nautilus, gnome-terminal and xchat do.
While i agree that it can be useful, it's also very confusing for people not expecting it. Imho we should optimize for the last category, if we want a way to go quickly to the start/end then alt+home/alt+end would be a better solution
Notice that Epiphany does do that. It looks like this used to be a limitation imposed somehow by the Gecko backend.
Thanks for pointing out about Epiphany behavior regards this subject. I also had a good conversation with the Gnome usability guys some time ago, you can check it at http://mail.gnome.org/archives/usability/2009-August/msg00006.html
<romulo> gnome-terminal, epiphany and nautilus wrap around We should do the same.
As Guillaume pointed, all those apps in 2.28 do it, and as Gustavo pointed too epiphany doesnt do it only when its using gecko, because of a limitation (that im not aware off). Also a patch for moving the tabs using shortcuts was proposed on IRC by an user, should i change my patch to include that too?
Here are my observations: Empathy: Cycle using alt-ctr-pageUP/DOWN. but not on ctr-pageUP/DOWN Epiphany: Cycle using alt-ctr-pageUP/DOWN and ctr-pageUP. but not on ctr-pageDOWN. gnome-terminal: Cycle using ctr-pageUP/DOWN. Not working at all with alt-ctr-pageUP/DOWN. gedit: Cycle using alt-ctr-pageUP/DOWN. Not working at all with ctr-pageUP/DOWN. nautilus: Cycle using ctr-pageUP/DOWN and alt-ctr-pageUP/DOWN. So out of 5 GNOME application there are not even 2 that does the same!!! that's a shame that should be fixed globally in GNOME and not only in Empathy.
Besides making a "standard" behavior, they should make some keys in gconf to make different modes for those who dont like the "standard"
There already exists a setting for this, the "gtk-keynav-wrap-around" GtkSetting.
Ctrl+PgDown works fine here with Epiphany. I'd say to use Ctrl+PgUp/PgDown in Empathy as that is what most GNOME app uses.
Sorry, it is ctr-pgUP that does cycle, at least with epiphany 2.28.0 using webkit.
Currently 17 Empathy tickets are set as GNOME 2.30 blockers, hence mass-removing. Guillaume: Please use normal Target Milestones instead. If you really think that this specific issue here is a 2.30 blocker then please restore the GNOME target and set corresponding importance values.
Review of attachment 138916 [details] [review]: Thanks for the patch; I merged it to master.
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Doesn't this now *always* cycle, even when gtk-keynav-wrap-around is 0 (FALSE) ?
Oh sorry Christian, I missed your comment. According to the documentation: "When TRUE, some widgets will wrap around when doing keyboard navigation, such as menus, menubars and notebooks." I didn't change this key so I guess I still have the default value (TRUE) but had to hack Empathy to get wrapping working (it does work with gnome-terminal and epiphany though). Should app checks the value of this key and cycle only when it's set to TRUE? That sounds strange to me; according the doc it seems to be something implemented in GTK+, not in the app.
*** Bug 601465 has been marked as a duplicate of this bug. ***
I think that yes, the app should check that setting value and only cycle when it's enabled. gtknotebook handles that internally for its switch-tab keybindings, but when you add your own additional keybindings, you have to do that yourself too.
Thanks for the info, I opened bug #601693 about this issue.