After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 589263 - Empathy next tab or previous tab doesnt cycle.
Empathy next tab or previous tab doesnt cycle.
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Chat
2.27.x
Other All
: Normal minor
: ---
Assigned To: empathy-maint
: 601465 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2009-07-21 15:24 UTC by Romulo Fernandes
Modified: 2011-08-29 10:12 UTC
See Also:
GNOME target: ---
GNOME version: 2.27/2.28


Attachments
Fixes cycling tab bug in chat window (3.52 KB, patch)
2009-07-21 15:27 UTC, Romulo Fernandes
committed Details | Review

Description Romulo Fernandes 2009-07-21 15:24:58 UTC
When you press "Next Tab" or "Previous Tab" menu items, if you are on the last tab, it goes to the first, and if you are on the first and press previous you go to the last.

Other information:
All applications work like that, why not empathy too?
Comment 1 Romulo Fernandes 2009-07-21 15:27:42 UTC
Created attachment 138916 [details] [review]
Fixes cycling tab bug in chat window
Comment 2 Guillaume Desmottes 2009-07-21 15:31:21 UTC
(In reply to comment #0)
> All applications work like that, why not empathy too?

Epiphany doesn't seem to do that.
Comment 3 Romulo Fernandes 2009-07-21 16:20:29 UTC
nautilus, gnome-terminal and xchat do.
Comment 4 Sjoerd Simons 2009-07-26 17:25:00 UTC
While i agree that it can be useful, it's also very confusing for people not expecting it. Imho we should optimize for the last category, if we want a way to go quickly to the start/end then alt+home/alt+end would be a better solution
Comment 5 Gustavo Noronha (kov) 2009-09-03 00:13:55 UTC
Notice that Epiphany does do that. It looks like this used to be a limitation imposed somehow by the Gecko backend.
Comment 6 Romulo Fernandes 2009-09-03 00:21:10 UTC
Thanks for pointing out about Epiphany behavior regards this subject. I also had a good conversation with the Gnome usability guys some time ago, you can check it at http://mail.gnome.org/archives/usability/2009-August/msg00006.html
Comment 7 Guillaume Desmottes 2009-10-26 12:19:07 UTC
<romulo> gnome-terminal, epiphany and nautilus wrap around

We should do the same.
Comment 8 Romulo Fernandes 2009-10-26 12:23:03 UTC
As Guillaume pointed, all those apps in 2.28 do it, and as Gustavo pointed too epiphany doesnt do it only when its using gecko, because of a limitation (that im not aware off). Also a patch for moving the tabs using shortcuts was proposed on IRC by an user, should i change my patch to include that too?
Comment 9 Xavier Claessens 2009-10-26 12:33:54 UTC
Here are my observations:

Empathy: Cycle using alt-ctr-pageUP/DOWN. but not on ctr-pageUP/DOWN
Epiphany: Cycle using alt-ctr-pageUP/DOWN and ctr-pageUP. but not on ctr-pageDOWN.
gnome-terminal: Cycle using ctr-pageUP/DOWN. Not working at all with alt-ctr-pageUP/DOWN.
gedit: Cycle using alt-ctr-pageUP/DOWN. Not working at all with ctr-pageUP/DOWN.
nautilus: Cycle using ctr-pageUP/DOWN and alt-ctr-pageUP/DOWN.

So out of 5 GNOME application there are not even 2 that does the same!!! that's a shame that should be fixed globally in GNOME and not only in Empathy.
Comment 10 Romulo Fernandes 2009-10-26 17:03:29 UTC
Besides making a "standard" behavior, they should make some keys in gconf to make different modes for those who dont like the "standard"
Comment 11 Christian Persch 2009-10-26 17:44:19 UTC
There already exists a setting for this, the "gtk-keynav-wrap-around" GtkSetting.
Comment 12 Guillaume Desmottes 2009-10-27 10:15:37 UTC
Ctrl+PgDown works fine here with Epiphany.

I'd say to use Ctrl+PgUp/PgDown in Empathy as that is what most GNOME app uses.
Comment 13 Xavier Claessens 2009-10-27 10:26:48 UTC
Sorry, it is ctr-pgUP that does cycle, at least with epiphany 2.28.0 using webkit.
Comment 14 André Klapper 2009-10-28 17:16:45 UTC
Currently 17 Empathy tickets are set as GNOME 2.30 blockers, hence mass-removing.
Guillaume: Please use normal Target Milestones instead. If you really think that this specific issue here is a 2.30 blocker then please restore the GNOME target and set corresponding importance values.
Comment 15 Guillaume Desmottes 2009-10-29 16:17:45 UTC
Review of attachment 138916 [details] [review]:

Thanks for the patch; I merged it to master.
Comment 16 Guillaume Desmottes 2009-10-29 16:18:23 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Comment 17 Christian Persch 2009-10-29 17:58:22 UTC
Doesn't this now *always* cycle, even when gtk-keynav-wrap-around is 0 (FALSE) ?
Comment 18 Guillaume Desmottes 2009-11-02 10:17:14 UTC
Oh sorry Christian, I missed your comment.
According to the documentation:

"When TRUE, some widgets will wrap around when doing keyboard navigation, such as menus, menubars and notebooks."

I didn't change this key so I guess I still have the default value (TRUE) but had to hack Empathy to get wrapping working (it does work with gnome-terminal and epiphany though). Should app checks the value of this key and cycle only when it's set to TRUE?
That sounds strange to me; according the doc it seems to be something implemented in GTK+, not in the app.
Comment 19 Frederic Peters 2009-11-10 23:23:20 UTC
*** Bug 601465 has been marked as a duplicate of this bug. ***
Comment 20 Christian Persch 2009-11-12 12:18:00 UTC
I think that yes, the app should check that setting value and only cycle when it's enabled. gtknotebook handles that internally for its switch-tab keybindings, but when you add your own additional keybindings, you have to do that yourself too.
Comment 21 Guillaume Desmottes 2009-11-12 13:49:03 UTC
Thanks for the info, I opened bug #601693 about this issue.