GNOME Bugzilla – Bug 589123
Brasero typo: should say finalizing instead of finalising.
Last modified: 2009-07-30 10:48:21 UTC
This report has been filed here: https://bugs.edge.launchpad.net/ubuntu/+source/brasero/+bug/401488 "Brasero disk burner has a typo. When the disk is finishing burning, the text in the window reads "finalising" when it should say "finalizing"." Thanks,
I couldn't fix this for 2.27 today but I managed to create a patch (2 actually) for 2.26.1, which is what I'm running right now. Patch 1 goes into the /po folder and patch 2 into the /src folder. It worked on my machine.
Created attachment 139249 [details] [review] Patch 1
Created attachment 139252 [details] [review] Patch 2
Created attachment 139254 [details] [review] Patch 1 corrected
The attached files above changes all instances of Finalise to Finalize in the .po files ( msgid ), and in the src/burn-basics.c sourcecode. In brasero-2.27.4 the burn-basics.c file is situated in libbrasero-burn instead of src/ . I attach patches for 2.74.4 ( only tested by re-creating the corrected files with the patch command. I haven't actually compiled and tried it but it should work... ;-)
Created attachment 139259 [details] [review] brasero-2.27.4 correction of .po files ..
Created attachment 139260 [details] [review] brasero-2.27.4 correction of /libbrasero-burn/burn-basics.c This file goes into /libbrasero-burn/ These are the very first patches I've produced so I hope the format is correct.
Thanks for the report and the patch. Oskar, you don't need to change the po files. They are regenerated by the translators with intltool-update. You just need to change the offending string in the code as you did in the latest patch (which is correct btw). As for the patches themselves, I am going to only use your latest as: - strings cannot be changed for stable version anymore - it is the one that actually fix the problem in unstable. I won't apply it right now as I will ask for a string break first. But as soon as the permission is given by translators, I'll commit it. Thanks again.
Translators were very responsive. I committed your last patch. Thanks again.