After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 589105 - Gnumeric 1.9.9 uses deprecated function from gtk2
Gnumeric 1.9.9 uses deprecated function from gtk2
Status: RESOLVED FIXED
Product: Gnumeric
Classification: Applications
Component: Compilation
1.9.x
Other All
: Normal minor
: ---
Assigned To: Jody Goldberg
Jody Goldberg
: 592489 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2009-07-20 09:31 UTC by Dominique Leuenberger
Modified: 2009-08-20 18:45 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Dominique Leuenberger 2009-07-20 09:31:14 UTC
Please describe the problem:
while comiling gnumeric 1.9.9 on top of gtk2 2.17.5, the following can be seen in the buildlog:

mv -f .deps/dialog-stf-format-page.Tpo .deps/dialog-stf-format-page.Plo
../../doltcompile gcc -DHAVE_CONFIG_H -I. -I../.. -DGNOMELOCALEDIR=\""/usr/share/locale"\" -DGNUMERIC_DATADIR=\""/usr/share/gnumeric/1.9.9"\" -I../.. -I../../src -I../../src/tools -DGNUMERIC_INTERNAL -DORBIT2=1 -pthread -I/usr/include/libgoffice-0.8 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/libgsf-1 -I/usr/include/libxml2 -I/usr/include/gtk-2.0 -I/usr/include/libglade-2.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/gconf/2 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng12 -I/usr/include/orbit-2.0 -I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include -fomit-frame-pointer -fmessage-length=0 -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector -funwind-tables -fasynchronous-unwind-tables -g -fno-strict-aliasing -DG_DISABLE_DEPRECATED -DPANGO_DISABLE_DEPRECATED -DGDK_PIXBUF_DISABLE_DEPRECATED -DGDK_DISABLE_DEPRECATED -DGDK_MULTIHEAD_SAFE -DGTK_DISABLE_DEPRECATED -DLIBGLADE_DISABLE_DEPRECATED -Wall -Wmissing-prototypes -Wsign-compare -Wpointer-arith -Wnested-externs -Wchar-subscripts -Wwrite-strings -Wdeclaration-after-statement -Wnested-externs -Wmissing-noreturn -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -Wno-pointer-sign -Werror=format-security -MT dialog-stf-preview.lo -MD -MP -MF .deps/dialog-stf-preview.Tpo -c -o dialog-stf-preview.lo dialog-stf-preview.c
dialog-stf-preview.c: In function 'stf_preview_get_cell_renderer':
dialog-stf-preview.c:300: warning: implicit declaration of function 'gtk_tree_view_column_get_cell_renderers'
dialog-stf-preview.c:300: warning: nested extern declaration of 'gtk_tree_view_column_get_cell_renderers'
dialog-stf-preview.c:300: warning: initialization makes pointer from integer without a cast

Steps to reproduce:
compile gnumeric with gtk2 2.17.5 (supposedly 2.17.2 or newer)

Actual results:
build 'warnings' as described above.

Expected results:
proper building

Does this happen every time?
yes

Other information:
It's a consequence of:
- bgo#562335: Deprecate gtk_tree_view_column_get_cell_renderers
Comment 1 Andreas J. Guelzow 2009-07-22 03:53:26 UTC
In view of bug 588025 you don't want to use gtk2 2.17.x with x > 2 anyways. 
Comment 2 Dominique Leuenberger 2009-07-22 20:27:04 UTC
Maybe it's worthy to try to undeprecate 
- bgo#562335: Deprecate gtk_tree_view_column_get_cell_renderers
to see if it's actually not just this one failing?

Just because code compiles without 'error' does not make it work.

Having 'implicit declared functions' is probably nothing that will make an application behave the way it's supposed to.

I somewhat could imaging that exactly this causes also the renderer not to work (from the bug you're pointing to).
Comment 3 Andreas J. Guelzow 2009-07-22 21:27:19 UTC
It really couldn't have anything to do with the bug I pointed to. The spreadsheet itself does not use these column renderers (the performance would be outrageously bad). 

You could always try to compile with out -DGTK_DISABLE_DEPRECATED.
Comment 4 Morten Welinder 2009-07-26 00:17:16 UTC
I am guessing that the busibodies want us to use gtk_cell_layout_get_cells
on GTK_CELL_LAYOUT(column).
Comment 5 Morten Welinder 2009-07-26 20:50:47 UTC
Fixed.  gtk_cell_layout_get_cells was in 2.12 which we already require.

This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Comment 6 Morten Welinder 2009-08-20 18:45:49 UTC
*** Bug 592489 has been marked as a duplicate of this bug. ***