After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 589091 - Feature Share My Desktop for Empathy
Feature Share My Desktop for Empathy
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: General
2.27.x
Other All
: Normal enhancement
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2009-07-20 08:19 UTC by Arnaud Maillet
Modified: 2009-08-05 16:45 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement



Description Arnaud Maillet 2009-07-20 08:19:54 UTC
Hello,

I submit my branch for Empathy, this branch allows a contact to share his desktop with en Empathy contact.

It calls a dbus method in Vino to share your desktop over the telepathy tubes.

the branch : http://git.collabora.co.uk/?p=user/ksz/empathy;a=shortlog;h=refs/heads/share-my-desktop

As regards
Comment 1 Guillaume Desmottes 2009-07-20 13:31:55 UTC
"make check" doesn't pass

empathy-share-my-desktop
• both files should be LGPL
• too bad to have this in libempathy-gtk but I guess we can't do otherwise?
• empathy_share_my_desktop_new_stream_tube: seems a poor name. _share_with_contact ?
• use DEBUG instead of g_printerr and g_debug. You should probably add a new debug domain
•       g_printerr ("The object path is null: %s\n", error_failed->message);  "CreateChannel failed: %s" is clearer
• empathy_share_my_desktop_channel_ready: "The connection is not ready:"  connection/channel

• Add a FIXME in empathy_contact_menu_new saying we should add the "Share my desktop" menu item if Vino is not a registered handler in MC5
• Add a FIXME in empathy_contact_share_my_desktop_menu_item_new saying we should check if the contact supports vnc stream tube
Comment 2 Arnaud Maillet 2009-07-20 14:12:45 UTC
It should be better now : 

http://git.collabora.co.uk/?p=user/ksz/empathy;a=shortlog;h=refs/heads/share-my-desktop

As regards
Comment 3 Guillaume Desmottes 2009-07-20 14:24:34 UTC
+  DEBUG ("Creation of ShareMyDesktop\n");
debug messages don't have to be trailed by a '\n'

+      return ;
No need for this extra space.

The commit msg of a5c443a87e4f1a5a0cb6ca8ea6511d0e88b73743 isn't very informative. Make it clearer.
Comment 5 Guillaume Desmottes 2009-07-20 15:33:32 UTC
Merged to master. Thanks!

Can you please open 2 bugs about the 2 FIXME I mentionned?