GNOME Bugzilla – Bug 589091
Feature Share My Desktop for Empathy
Last modified: 2009-08-05 16:45:14 UTC
Hello, I submit my branch for Empathy, this branch allows a contact to share his desktop with en Empathy contact. It calls a dbus method in Vino to share your desktop over the telepathy tubes. the branch : http://git.collabora.co.uk/?p=user/ksz/empathy;a=shortlog;h=refs/heads/share-my-desktop As regards
"make check" doesn't pass empathy-share-my-desktop • both files should be LGPL • too bad to have this in libempathy-gtk but I guess we can't do otherwise? • empathy_share_my_desktop_new_stream_tube: seems a poor name. _share_with_contact ? • use DEBUG instead of g_printerr and g_debug. You should probably add a new debug domain • g_printerr ("The object path is null: %s\n", error_failed->message); "CreateChannel failed: %s" is clearer • empathy_share_my_desktop_channel_ready: "The connection is not ready:" connection/channel • Add a FIXME in empathy_contact_menu_new saying we should add the "Share my desktop" menu item if Vino is not a registered handler in MC5 • Add a FIXME in empathy_contact_share_my_desktop_menu_item_new saying we should check if the contact supports vnc stream tube
It should be better now : http://git.collabora.co.uk/?p=user/ksz/empathy;a=shortlog;h=refs/heads/share-my-desktop As regards
+ DEBUG ("Creation of ShareMyDesktop\n"); debug messages don't have to be trailed by a '\n' + return ; No need for this extra space. The commit msg of a5c443a87e4f1a5a0cb6ca8ea6511d0e88b73743 isn't very informative. Make it clearer.
Done: http://git.collabora.co.uk/?p=user/ksz/empathy;a=shortlog;h=refs/heads/share-my-desktop
Merged to master. Thanks! Can you please open 2 bugs about the 2 FIXME I mentionned?