After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 589029 - Support for Samsung Android Device (Galaxy alias GT-I7500
Support for Samsung Android Device (Galaxy alias GT-I7500
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: Device - USB Mass Storage
1.4.3
Other All
: Normal enhancement
: 1.x
Assigned To: Gabriel Burt
Gabriel Burt
Depends on:
Blocks:
 
 
Reported: 2009-07-19 14:48 UTC by Johannes Kuhn
Modified: 2009-07-31 19:58 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch Fixing Galaxy Support (651 bytes, patch)
2009-07-20 21:26 UTC, Johannes Kuhn
reviewed Details | Review
Patch to Fix Samsung Galaxy support (656 bytes, patch)
2009-07-31 15:56 UTC, Johannes Kuhn
committed Details | Review

Description Johannes Kuhn 2009-07-19 14:48:57 UTC
I would love to see the Samsung Galaxy supported in Banshee. It should be quiet similar to the HTC G1.

Vendor-name: Samsung 
Vendor-id: 0x04e8
Product-id: 0x6603

I would love to add it myself but i have no clue how i have to start. I guess adding an entry to Banshee.Dap.MassStorage.addin.xml and recompiling might do?!
Comment 1 Bertrand Lorentz 2009-07-19 18:05:28 UTC
Yes, adding a line like the following in Banshee.Dap.MassStorage.addin.xml might do the trick :

    <MassStorageDevice class="Banshee.Dap.MassStorage.AndroidDevice" 
        vendor-name="Samsung" product-name="Galaxy"
        vendor-id="0x04e8" product-id="0x6603"/>

If it works, please attach a patch here, so that we can include this in the next release.
Comment 2 Johannes Kuhn 2009-07-20 21:26:09 UTC
Created attachment 138855 [details] [review]
Patch Fixing Galaxy Support
Comment 3 Johannes Kuhn 2009-07-20 21:27:22 UTC
My Patch worked perfectly on Gentoo Linux.
Comment 4 Bertrand Lorentz 2009-07-22 19:49:25 UTC
Thanks for the patch !
Were you able to check that everything works like on the G1 : cover art, Amazon store, etc. ?

Now if only I could get one of these where I live... :(
Comment 5 Johannes Kuhn 2009-07-31 15:56:22 UTC
Created attachment 139634 [details] [review]
Patch to Fix Samsung Galaxy support

Added support for Galaxies "USB-Debug-Mode" in Banshee. Now it is recognised by Banshee both in Massstorage-Mode and in Debug-Mode.
Comment 6 Johannes Kuhn 2009-07-31 15:59:26 UTC
Yes those Patches seem to work both just fine. Cover Art gets exported to the Phone and shows up fine. I can not test Amazon Support, as there is no Support for it in Germany (I wish i could use Amazon natively with that Phone).
Comment 7 Bertrand Lorentz 2009-07-31 19:58:25 UTC
Thanks for the patch !

I just committed it, with a few cosmetic changes.

For the future, please create your patches from a recent git checkout. This didn't make any difference in this case, but I thought I'd mention it.