After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 588979 - Use correct Name and GenericName in .desktop file
Use correct Name and GenericName in .desktop file
Status: RESOLVED OBSOLETE
Product: epiphany
Classification: Core
Component: General
2.27.x
Other Linux
: Normal trivial
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks: 588975
 
 
Reported: 2009-07-18 19:41 UTC by Javier Jardón (IRC: jjardon)
Modified: 2012-02-17 20:51 UTC
See Also:
GNOME target: ---
GNOME version: 2.27/2.28


Attachments
Use correct Name in .desktop file (696 bytes, patch)
2009-07-18 19:43 UTC, Javier Jardón (IRC: jjardon)
none Details | Review
Use correct Name and GenericName in .desktop file v2 (720 bytes, patch)
2009-08-22 18:01 UTC, Javier Jardón (IRC: jjardon)
none Details | Review
Fix .desktop file (711 bytes, patch)
2009-08-27 00:03 UTC, Javier Jardón (IRC: jjardon)
none Details | Review
Use correct Name, GenericName in bme.desktop (735 bytes, patch)
2010-02-10 15:59 UTC, Diego Escalante Urrelo (not reading bugmail)
rejected Details | Review

Description Javier Jardón (IRC: jjardon) 2009-07-18 19:41:16 UTC
See http://live.gnome.org/GnomeGoals/CorrectGenericName
Comment 1 Javier Jardón (IRC: jjardon) 2009-07-18 19:43:56 UTC
Created attachment 138701 [details] [review]
Use correct Name in .desktop file
Comment 2 Javier Jardón (IRC: jjardon) 2009-08-22 18:01:03 UTC
Created attachment 141437 [details] [review]
Use correct Name and GenericName in .desktop file v2

This is now a offical GnomeGoal: http://live.gnome.org/GnomeGoals/CorrectDesktopFiles
Comment 3 Javier Jardón (IRC: jjardon) 2009-08-27 00:03:47 UTC
Created attachment 141811 [details] [review]
Fix .desktop file

It was finally decided to use X-GNOME-FullName, as the key is GNOME specific
Comment 4 Xan Lopez 2009-08-31 15:12:10 UTC
This is fixed in master, will be in 2.27.92
Comment 5 Luca Ferretti 2009-08-31 18:06:59 UTC
You forgot bme.desktop

[Desktop Entry]
_Name=Epiphany Web Bookmarks
_GenericName=Web Bookmarks
_Comment=Browse and organize your bookmarks
Exec=epiphany --bookmarks-editor

PS here is a way to reopen a bug?
Comment 6 Javier Jardón (IRC: jjardon) 2010-02-07 21:42:45 UTC
Reoponed, as Luca said bme.desktop needs to be patched
Comment 7 Diego Escalante Urrelo (not reading bugmail) 2010-02-10 15:59:47 UTC
Created attachment 153424 [details] [review]
Use correct Name, GenericName in bme.desktop

Bug #588979
Comment 8 Diego Escalante Urrelo (not reading bugmail) 2010-02-10 17:15:27 UTC
Tried this a bit and I think we should keep it as is, using only Epiphany as the name is confusing.
So I'm proposing my patch as only adding _X-GNOME-FullName.

diff --git a/data/bme.desktop.in.in b/data/bme.desktop.in.in
index 97572d4..9ead747 100644
--- a/data/bme.desktop.in.in
+++ b/data/bme.desktop.in.in
@@ -1,6 +1,7 @@
 [Desktop Entry]
 _Name=Epiphany Web Bookmarks
 _GenericName=Web Bookmarks
+_X-GNOME-FullName=Epiphany Web Bookmarks
Comment 9 Luca Ferretti 2010-02-10 18:04:58 UTC
Diego, the only other GNOME app with similar need is Brasero. It's using "_Name=Brasero" in both brasero-copy-medium.desktop (GN=Disc copier) and brasero.desktop (GN=Disc Burner).

However the fist one is hidden in Application menu.
Comment 10 Javier Jardón (IRC: jjardon) 2010-07-15 18:31:38 UTC
So, any final solution here?
Comment 11 Diego Escalante Urrelo (not reading bugmail) 2012-02-17 20:51:54 UTC
We do not ship BME.desktop anymore.