After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 588777 - [souphttpsrc] don't try to authenticate if no username/password is set
[souphttpsrc] don't try to authenticate if no username/password is set
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other All
: Normal normal
: 0.10.16
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-07-16 13:17 UTC by Arnout Vandecappelle
Modified: 2009-07-16 15:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
souphttpsrc: don't try to authenticate if no username/password is set (1.21 KB, patch)
2009-07-16 13:22 UTC, Arnout Vandecappelle 		committed Details | Review

Description Arnout Vandecappelle 2009-07-16 13:17:56 UTC 
When souphttpsrc receives the "authenticate" signal from soup, it tries to authenticate the connection with the username and password that are set as properties on the element.  However, if username or password are NULL, this triggers a 

libsoup-CRITICAL **: soup_auth_authenticate: assertion `username != NULL' failed

The attached patch doesn't try to authenticate if username or password is NULL.
Comment 1 Arnout Vandecappelle 2009-07-16 13:22:44 UTC 
Created attachment 138531 [details] [review]
souphttpsrc: don't try to authenticate if no username/password is set
Comment 2 Sebastian Dröge (slomo) 2009-07-16 15:15:01 UTC 
Thanks, committed :)

commit 07c454d61ec014334812517e24aa694552dbe03d
Author: Arnout Vandecappelle <arnout@mind.be>
Date:   Thu Jul 16 15:14:43 2009 +0200

    souphttpsrc: don't try to authenticate if no username/password is set.