After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 588724 - [vorbisdec] empty encoder string causes GStreamer
[vorbisdec] empty encoder string causes GStreamer
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal blocker
: 0.10.24
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-07-15 22:58 UTC by Philip Jägenstedt
Modified: 2009-07-16 12:16 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
vorbisdec: Check for empty tag strings. Fixes #588724 (940 bytes, patch)
2009-07-16 07:31 UTC, Edward Hervey
committed Details | Review

Description Philip Jägenstedt 2009-07-15 22:58:29 UTC
http://www.archive.org/download/street_angel/street_angel.ogv

This file has an empty encoder (vendor) string (presumably produced by broken ffmpeg encoder). It causes this warning:

GStreamer-WARNING **: Trying to set empty string on taglist field 'encoder'. Please file a bug.
aborting...

  • #0 raise
    from /lib/libc.so.6
  • #1 abort
    from /lib/libc.so.6
  • #2 IA__g_logv
    at /build/buildd/glib2.0-2.20.1/glib/gmessages.c line 506
  • #3 IA__g_log
    at /build/buildd/glib2.0-2.20.1/glib/gmessages.c line 526
  • #4 gst_structure_set_field
    at gststructure.c line 667
  • #5 gst_structure_id_set_value
    at gststructure.c line 447
  • #6 gst_tag_list_add_value_internal
    at gsttaglist.c line 688
  • #7 gst_tag_list_add_valist
    at gsttaglist.c line 920
  • #8 gst_tag_list_add
    at gsttaglist.c line 849
  • #9 vorbis_handle_comment_packet
    at vorbisdec.c line 729
  • #10 vorbis_handle_header_packet
    at vorbisdec.c line 836
  • #11 vorbis_dec_decode_buffer
    at vorbisdec.c line 1186
  • #12 vorbis_dec_chain_forward
    at vorbisdec.c line 1399
  • #13 vorbis_dec_chain
    at vorbisdec.c line 1431
  • #14 gst_pad_chain_data_unchecked
    at gstpad.c line 4063
  • #15 gst_pad_chain
    at gstpad.c line 4196
  • #16 gst_ogg_demux_chain_elem_pad
    at gstoggdemux.c line 805
  • #17 gst_ogg_pad_submit_packet
    at gstoggdemux.c line 995
  • #18 gst_ogg_pad_stream_out
    at gstoggdemux.c line 1080
  • #19 gst_ogg_pad_submit_page
    at gstoggdemux.c line 1152
  • #20 gst_ogg_demux_handle_page
    at gstoggdemux.c line 2901
  • #21 gst_ogg_demux_chain
    at gstoggdemux.c line 2946
  • #22 gst_pad_chain_data_unchecked
    at gstpad.c line 4063
  • #23 gst_pad_push_data
    at gstpad.c line 4293
  • #24 gst_pad_push
    at gstpad.c line 4398
  • #25 stop_typefinding
    at gsttypefindelement.c line 484
  • #26 gst_type_find_element_chain_do_typefinding
    at gsttypefindelement.c line 767
  • #27 gst_type_find_element_chain
    at gsttypefindelement.c line 704
  • #28 gst_pad_chain_data_unchecked
    at gstpad.c line 4063
  • #29 gst_pad_push_data
    at gstpad.c line 4293
  • #30 gst_pad_push
    at gstpad.c line 4398
  • #31 gst_proxy_pad_do_chain
    at gstghostpad.c line 179
  • #32 gst_pad_chain_data_unchecked
    at gstpad.c line 4063
  • #33 gst_pad_push_data
    at gstpad.c line 4293
  • #34 gst_pad_push
    at gstpad.c line 4398
  • #35 gst_base_src_loop
    at gstbasesrc.c line 2290
  • #36 gst_task_func
    at gsttask.c line 234
  • #37 default_func
    at gsttaskpool.c line 70
  • #38 g_thread_pool_thread_proxy
    at /build/buildd/glib2.0-2.20.1/glib/gthreadpool.c line 265
  • #39 g_thread_create_proxy
    at /build/buildd/glib2.0-2.20.1/glib/gthread.c line 635
  • #40 start_thread
    from /lib/libpthread.so.0
  • #41 clone
    from /lib/libc.so.6
  • #42 ??

Should be an easy fix by just checking for the empty string around vorbisdec.c:729
Comment 1 Edward Hervey 2009-07-16 07:31:40 UTC
Created attachment 138511 [details] [review]
vorbisdec: Check for empty tag strings. Fixes #588724
Comment 2 Jan Schmidt 2009-07-16 12:02:46 UTC
This should go in the current release, as the empty-tags warnings are new (so the warning message constitutes something of a regression)
Comment 3 Edward Hervey 2009-07-16 12:16:24 UTC
commit 47d40c2553a25e0f1ccc2fb6ad71662e0dad0941
Author: Edward Hervey <bilboed@bilboed.com>
Date:   Thu Jul 16 09:32:46 2009 +0200

    vorbisdec: Check for empty tag strings. Fixes #588724