After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 588550 - build failure in git, missing gstinterfaces-0.10
build failure in git, missing gstinterfaces-0.10
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: 0.10.24
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-07-14 15:25 UTC by Björn Lindqvist
Modified: 2009-07-15 14:57 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
examples: fix v4l probe example build (1.02 KB, patch)
2009-07-14 17:07 UTC, Filippo Argiolas
none Details | Review
examples: fix v4l probe example build (1009 bytes, patch)
2009-07-15 13:33 UTC, Filippo Argiolas
committed Details | Review

Description Björn Lindqvist 2009-07-14 15:25:21 UTC
gst-plugins-base from git refuses to build:

  CC    sprinkle2-sprinkle2.o
  LINK  sprinkle2
  CC    sprinkle3-sprinkle3.o
  LINK  sprinkle3
Making all in v4l
  CC    probe-probe.o
  LINK  probe
/usr/bin/ld: cannot find -lgstinterfaces-0.10
collect2: ld returned 1 exit status
Comment 1 Filippo Argiolas 2009-07-14 17:07:37 UTC
Created attachment 138405 [details] [review]
examples: fix v4l probe example build

Fixes bug #588550.
Comment 2 Filippo Argiolas 2009-07-14 17:09:07 UTC
Sorry my fault, not sure why it builded fine here. Is the same change needed for the correspondent example in -good? Does it build fine for you?
Comment 3 Jan Schmidt 2009-07-15 12:34:58 UTC
It probably builds fine if you have an installed copy of libgstinterfaces on the system...

In the patch, $(GST_PLUGINS_BASE_CFLAGS) should precede $(GST_BASE_CFLAGS) (local module stuff goes first) - and the same for the LIBS. There's no need to manually add -I$(top_builddir)/gst-libs to the CFLAGS - only to add the .la file to the LIBS. 
Comment 4 Filippo Argiolas 2009-07-15 13:32:27 UTC
(In reply to comment #3)
> In the patch, $(GST_PLUGINS_BASE_CFLAGS) should precede $(GST_BASE_CFLAGS)
> (local module stuff goes first) - and the same for the LIBS. There's no need to
> manually add -I$(top_builddir)/gst-libs to the CFLAGS - only to add the .la
> file to the LIBS. 

Oh... I almost copied it from seek/Makefile.am, but it uses AM_FLAGS and LDADD maybe it's different (or maybe it is wrong too), I'm not so good with autotools :-P
New patch following.



Comment 5 Filippo Argiolas 2009-07-15 13:33:32 UTC
Created attachment 138440 [details] [review]
examples: fix v4l probe example build

Fixes bug #588550.
Comment 6 Jan Schmidt 2009-07-15 13:52:54 UTC
seek is wrong too, but it can wait :)

Please commit.
Comment 7 Filippo Argiolas 2009-07-15 14:46:07 UTC
commit 57d8ba0fd20fccfa257bbfc0b72e2fdb4f001a4f
Author: Filippo Argiolas <filippo.argiolas@gmail.com>
Date:   Tue Jul 14 19:00:36 2009 +0200

    examples: fix v4l probe example build
    
    Fixes bug #588550.
Comment 8 Jan Schmidt 2009-07-15 14:57:39 UTC
don't forget to set the milestone when closing bugs....