GNOME Bugzilla – Bug 588232
Push Button 4/5 events to compositor even when no matching MetaWindow exists
Last modified: 2009-07-31 14:38:01 UTC
Currently, the compositor will only see button 4/5 events if the event window is managed by Mutter, but if we are getting the event for a non-managed window, it implies that some plugin selected to receive these, so we should not block these.
Created attachment 138179 [details] [review] The patch as we have it in moblin
See my suggested better way to do things in bug 580760
I assume you are referring to letting the event fall through to the end of the switch statement ?
Yes. I was saying there the early return: A) Makes it hard to understand what is going on B) Makes it easy to make mistakes where the scroll events get handled differently from other events. If you look at my untested alternative patch there, it doesn't have the problem you are fixing in this patch.
Created attachment 139439 [details] [review] Pass through all scroll events to compositor I've tested: - Scrolling over a title bar doesn't cause any apparent bad effects - Scroll events get through to the clutter canvas
Yep, that's lot cleaner, would you commit it please ?
Pushed.