After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 588196 - gok fails to build on non-linux systems
gok fails to build on non-linux systems
Status: RESOLVED FIXED
Product: gok
Classification: Deprecated
Component: build
2.27.x
Other Linux
: Normal normal
: ---
Assigned To: David Bolter
David Bolter
: 509838 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2009-07-09 20:54 UTC by Emilio Pozuelo Monfort
Modified: 2009-09-24 15:03 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
check for preprocessos macros with #if defined (703 bytes, patch)
2009-07-09 20:55 UTC, Emilio Pozuelo Monfort 		accepted-commit_now Details | Review

Description Emilio Pozuelo Monfort 2009-07-09 20:54:43 UTC 
[ Forwarded from http://bugs.debian.org/460863 ]

Hi,

The following patch from Debian fixes a build issue on non-Linux systems, where that preprocessor are not defined, and thus should be checked with #ifdef or #if defined.
Comment 1 Emilio Pozuelo Monfort 2009-07-09 20:55:22 UTC 
Created attachment 138147 [details] [review]
check for preprocessos macros with #if defined
Comment 2 Emilio Pozuelo Monfort 2009-09-13 16:25:39 UTC 
This fix is trivial, can we get it in for 2.28 please?
Comment 3 Gerd Kohlberger 2009-09-17 15:54:18 UTC 
Sorry Emilio, I forgot about this bug and now we're already in hard code freeze for 2.28.

Ben, could you please take a look at this patch. I think it's save to commit, but I'm not familiar with the libusb part.
Comment 4 Gerd Kohlberger 2009-09-17 15:56:56 UTC 
*** Bug 509838 has been marked as a duplicate of this bug. ***
Comment 5 Ben Konrath 2009-09-18 15:52:25 UTC 
Gerd, the patch is safe to commit. Thanks, Ben