GNOME Bugzilla – Bug 588040
support xrandr 1.3 'primary output'
Last modified: 2010-01-26 23:17:24 UTC
Xrandr adds a concept of 'primary output' which is supposed to be the monitor on which the desktop displays its main panels/menus. Here is a patch which adds a <primary> tag to the <output> elements in monitor.xml, and adds new api gboolean gnome_rr_output_get_primary (GnomeRROutput *output); +void gnome_rr_output_set_primary (GnomeRROutput *output); If Xrandr 1.3 is not available, this should silently do nothing. Lightly tested.
Created attachment 138015 [details] [review] patch
Federico: can you review this?
Note to self: bug #588041 has a patch to make gnome-display-properties use this Primary property for the "Include panel" checkbox.
Vuntz says that we are API frozen, but gnome-desktop is in the desktop modules. Please go ahead and commit with the following changes: - s/gnome_rr_output_get_primary/gnome_rr_output_get_is_primary - Make gnome_rr_output_set_primary() take both a GnomeRRScreen and an output. If output == NULL, make it call XRRSetOutputPrimary(..., None). Hmm, maybe this function should be called gnome_rr_screen_set_primary_output() instead? - In crtc_assignment_apply(), I think you'll want to call set_primary(..., NULL) right after grabbing the display (i.e. disable any primary outputs there were). Don't commit the changes to gnome-control-center just yet... I want to see what the panel requires, and what kind of UI we want for this. Gnome-shell may indeed require the concept of a primary output, so let's keep this API available in gnome-desktop for now.
Committed with the requested changes.
Hmm, did you forget to commit the requested changes? :)
I put a patch in bug 562944 for gnome-panel.
I assume this can be marked as resolved if its been committed?
588041 doesn't actually have any attachments. Was anything commited?
Federico, Jeremy, Nick the changes are commited in http://git.gnome.org/cgit/gnome-desktop/commit/?id=ac466a59aa7b68d1502431a634fce788c176007f and http://git.gnome.org/cgit/gnome-desktop/commit/?id=a55608b35ad8d17af86a303795c6b3f777b2dfcc I think.
This is committed indeed. Closing the bug.
Asking here just in case: Does anybody here have the patch that was supposed to be attached to related bug #588041, which is enables the GUI for this option?
Sadly I have no idea how to get that patch. The downstream bugreport for it at https://bugzilla.redhat.com/show_bug.cgi?id=510145 does not have anything attached either. In addition the bug is referenced to from https://bugzilla.gnome.org/show_bug.cgi?id=562944#c27 ... How this should look like is shown in https://bugzilla.gnome.org/show_bug.cgi?id=562944#c5