After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 587980 - gstchannelmix.c: protect debug code with GST_DISABLE_GST_DEBUG
gstchannelmix.c: protect debug code with GST_DISABLE_GST_DEBUG
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Windows
: Normal normal
: 0.10.24
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-07-07 14:26 UTC by Philip Jägenstedt
Modified: 2009-07-08 13:09 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
proposed solution (876 bytes, patch)
2009-07-07 14:29 UTC, Philip Jägenstedt
none Details | Review
updated as per ds's suggestions (1.69 KB, patch)
2009-07-08 08:17 UTC, Philip Jägenstedt
committed Details | Review

Description Philip Jägenstedt 2009-07-07 14:26:18 UTC
Some debug code isn't properly protected. See proposed patch.
Comment 1 Philip Jägenstedt 2009-07-07 14:29:14 UTC
Created attachment 137971 [details] [review]
proposed solution
Comment 2 Tim-Philipp Müller 2009-07-07 19:10:24 UTC
How about a patch that adds -Wno-warn-on-unused-variables-or-whatever-it-is to ERROR_CFLAGS when debugging is disabled in core instead? ;)
Comment 3 Philip Jägenstedt 2009-07-07 19:27:59 UTC
To be clear, the code doesn't generate any warnings with debugging on or off that I've seen, that's not why I made the change. The compiler still can't optimize away any of those string operations even with debugging disabled.
Comment 4 David Schleef 2009-07-08 00:36:33 UTC
As a minor improvement, I'd suggest using

#ifndef GST_DISABLE_GST_DEBUG
 {
    char *s;
    stuff
    GST_LOG();
 }
#endif
Comment 5 Philip Jägenstedt 2009-07-08 08:17:11 UTC
Created attachment 138020 [details] [review]
updated as per ds's suggestions

OK, updated patch here.
Comment 6 Sebastian Dröge (slomo) 2009-07-08 13:09:16 UTC
commit fa0a5a667f5dd1df04970fff881df160d03b08a2
Author: Philip Jägenstedt <philipj@opera.com>
Date:   Wed Jul 8 15:08:32 2009 +0200

    audioconvert: Fix compilation when debugging is disabled
    
    Fixes bug #587980.