GNOME Bugzilla – Bug 587980
gstchannelmix.c: protect debug code with GST_DISABLE_GST_DEBUG
Last modified: 2009-07-08 13:09:16 UTC
Some debug code isn't properly protected. See proposed patch.
Created attachment 137971 [details] [review] proposed solution
How about a patch that adds -Wno-warn-on-unused-variables-or-whatever-it-is to ERROR_CFLAGS when debugging is disabled in core instead? ;)
To be clear, the code doesn't generate any warnings with debugging on or off that I've seen, that's not why I made the change. The compiler still can't optimize away any of those string operations even with debugging disabled.
As a minor improvement, I'd suggest using #ifndef GST_DISABLE_GST_DEBUG { char *s; stuff GST_LOG(); } #endif
Created attachment 138020 [details] [review] updated as per ds's suggestions OK, updated patch here.
commit fa0a5a667f5dd1df04970fff881df160d03b08a2 Author: Philip Jägenstedt <philipj@opera.com> Date: Wed Jul 8 15:08:32 2009 +0200 audioconvert: Fix compilation when debugging is disabled Fixes bug #587980.