After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 587976 - Fix for gst-inspect and gst-launch when option parsing is disabled
Fix for gst-inspect and gst-launch when option parsing is disabled
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Windows
: Normal normal
: 0.10.24
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-07-07 13:59 UTC by Philip Jägenstedt
Modified: 2009-07-08 13:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
suggested fix (2.28 KB, patch)
2009-07-07 14:00 UTC, Philip Jägenstedt 		committed Details | Review

Description Philip Jägenstedt 2009-07-07 13:59:41 UTC 
This fix may not be of great general use, but I'll submit it for consideration. With GST_DISABLE_OPTION_PARSING gst_init_get_option_group won't actually do init, which the code assumes. The result is that gst is uninitialized, you get asserts, catastrophic failure and so on. Could be fixed in gst_init_get_option_group, but I've opted for this solution because it removes the dependency on GOption completely and parsing only glib options but not gst options doesn't seem too useful.
Comment 1 Philip Jägenstedt 2009-07-07 14:00:40 UTC 
Created attachment 137969 [details] [review]
suggested fix
Comment 2 Sebastian Dröge (slomo) 2009-07-08 13:16:30 UTC 
IMHO this fix is correct. People using gst_init_get_option_group() should make sure that the return value is not NULL or should check if  GST_DISABLE_OPTION_PARSING is defined.


commit 9501767704f5baa180db20270af04b1b657a3a32
Author: Philip Jägenstedt <philipj@opera.com>
Date:   Wed Jul 8 15:15:04 2009 +0200

    tools: Fix compilation if option parsing is disabled
    
    Fixes bug #587976.