After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 587973 - use G_DIR_SEPARATOR_S instead of "/'"
use G_DIR_SEPARATOR_S instead of "/'"
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Windows
: Normal normal
: 0.10.24
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-07-07 13:51 UTC by Philip Jägenstedt
Modified: 2009-07-08 13:11 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
trivial patch, but here you have it (582 bytes, patch)
2009-07-07 13:52 UTC, Philip Jägenstedt 		none Details | Review

Description Philip Jägenstedt 2009-07-07 13:51:38 UTC 
gstregistry.c builds the path of the module to load using "/", which is wrong on that other OS that uses \. Actually it worked, but the resulting string is still inconsistent and I'm not sure if it might cause problems on older version of that other OS.
Comment 1 Philip Jägenstedt 2009-07-07 13:52:19 UTC 
Created attachment 137968 [details] [review]
trivial patch, but here you have it
Comment 2 Sebastian Dröge (slomo) 2009-07-07 18:04:53 UTC 
Better would probably be a call to g_build_filename() which handles this automatically
Comment 3 Philip Jägenstedt 2009-07-07 19:30:56 UTC 
Sure, that would be fine too.
Comment 4 Sebastian Dröge (slomo) 2009-07-08 13:11:50 UTC 
commit 45876e11cbe1136efdb8b6355ba0efc0e014d4c5
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Wed Jul 8 15:10:26 2009 +0200

    registry: Use g_build_filename() instead of g_strjoin() with /
    
    This makes sure that the generated filenames use the platform
    specific directory separator instead of /.
    
    Fixes bug #587973.