After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 587945 - editing_context and advanced_editing_modes branches
editing_context and advanced_editing_modes branches
Status: RESOLVED FIXED
Product: pitivi
Classification: Other
Component: Code review
Git
Other Linux
: Normal normal
: 0.13.2
Assigned To: Alessandro Decina
Depends on:
Blocks:
 
 
Reported: 2009-07-07 06:12 UTC by Brandon Lewis
Modified: 2009-07-10 10:19 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Brandon Lewis 2009-07-07 06:12:29 UTC 
I have two related branches for supporting ripple / roll editing, available on my github account (www.github.com/~emdash/pitivi.git). The first branch is basically just the foundation for ripple roll support, and could be merged immediately if it passes review. The advanced_editing_modes branch is still pretty unstable, but a good illustration of where I'm going with this.
Comment 1 Brandon Lewis 2009-07-07 06:13:05 UTC 
Correction, that's "advanced_edit_modes".
Comment 2 Alessandro Decina 2009-07-07 08:23:28 UTC 
I'm reviewing this (i had a quick look and it seems okayish)
Comment 3 Alessandro Decina 2009-07-08 18:11:39 UTC 
I did the review. The EditingContext stuff looks good. The tests need some work though (they just test some coverage).

Some of the changes were conflicting with a branch i had on my local repo that fixed TimelineEdges a bit, so I merged our branches and pushed it here http://github.com/alessandrod/pitivi/tree/editing_context
Comment 4 Alessandro Decina 2009-07-10 10:19:42 UTC 
I fixed the tests and merged into master.