After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 587695 - Patches to add stream-status messages audio elements
Patches to add stream-status messages audio elements
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal blocker
: 0.10.24
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-07-03 16:52 UTC by Olivier Crête
Modified: 2009-07-20 10:55 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
audiosrc: Add stream-status messages (1.98 KB, patch)
2009-07-03 16:53 UTC, Olivier Crête
committed Details | Review
audiosink: Add stream-status messages (2.02 KB, patch)
2009-07-03 16:53 UTC, Olivier Crête
committed Details | Review
pulsesink: Emit stream-status enter message (2.83 KB, patch)
2009-07-03 16:53 UTC, Olivier Crête
committed Details | Review
pulsesink: Emit stream-status leave message (2.21 KB, patch)
2009-07-03 16:53 UTC, Olivier Crête
committed Details | Review

Description Olivier Crête 2009-07-03 16:52:29 UTC
I'm attaching patches that will emit the ENTER/LEAVE messages on the ringbuffer thread in GstAudioSrc/Sink.

I'm also attaching patches for pulsesink that try to emit them from the pulseaudio mainloop thread.
Comment 1 Olivier Crête 2009-07-03 16:53:30 UTC
Created attachment 137793 [details] [review]
audiosrc: Add stream-status messages
Comment 2 Olivier Crête 2009-07-03 16:53:32 UTC
Created attachment 137794 [details] [review]
audiosink: Add stream-status messages
Comment 3 Olivier Crête 2009-07-03 16:53:47 UTC
Created attachment 137795 [details] [review]
pulsesink: Emit stream-status enter message
Comment 4 Olivier Crête 2009-07-03 16:53:49 UTC
Created attachment 137796 [details] [review]
pulsesink: Emit stream-status leave message
Comment 5 Wim Taymans 2009-07-14 16:54:42 UTC
changed so that we use the pulse mainloop signal and locking instead of the custom GCond.

commit dbb8a331de95d486a80a055029f4af9e9d82d87e
Author: Olivier Crête <olivier.crete@collabora.co.uk>
Date:   Fri Jul 3 05:11:26 2009 -0400

    pulsesink: Emit stream-status leave message
    
    Fixes #587695

commit b2e9f0a7c9123284b6a806a59b519f9e1e9f2392
Author: Olivier Crête <olivier.crete@collabora.co.uk>
Date:   Fri Jul 3 05:06:45 2009 -0400

    pulsesink: Emit stream-status enter message
    
    Emit stream-status messages for the pulse thread.
    Don't use our own GCond for signaling but simply use the pulse mainloop
    mechanisms for synchronisation.
    See #587695
Comment 6 Wim Taymans 2009-07-14 16:56:18 UTC
I would also like to get the patches for the base classes into the release.
Comment 7 Jan Schmidt 2009-07-15 13:16:55 UTC
sure, why not?
Comment 8 Wim Taymans 2009-07-20 10:55:35 UTC
commit 4e88633de4f301b93291a81bdc850da3a6c3d965
Author: Olivier Crête <olivier.crete@collabora.co.uk>
Date:   Fri Jul 3 04:42:24 2009 -0400

    audiosink: Add stream-status messages
    
    Fixes #587695

commit cc0da016f802e698ba4bc34997139ae62c935bb8
Author: Olivier Crête <olivier.crete@collabora.co.uk>
Date:   Fri Jul 3 04:41:05 2009 -0400

    audiosrc: Add stream-status messages
    
    See #587695