After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 587684 - building gegl fails in operations/workshop/external
building gegl fails in operations/workshop/external
Status: RESOLVED FIXED
Product: GEGL
Classification: Other
Component: build
0.1.0
Other Linux
: Normal normal
: 0.1.2
Assigned To: Default Gegl Component Owner
Depends on:
Blocks:
 
 
Reported: 2009-07-03 13:48 UTC by Nils Philippsen
Modified: 2009-07-14 20:17 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed patch which adds missing $(GLIB_CFLAGS), $(BABL_CFLAGS) to operations/workshop/external/Makefile.am (1.54 KB, patch)
2009-07-03 13:49 UTC, Nils Philippsen
committed Details | Review

Description Nils Philippsen 2009-07-03 13:48:14 UTC
compiling fails thusly:

[...]
make[4]: Entering directory `/home/nils/devel/cvs/fedora/gegl/devel/gegl-0.1.0/operations/workshop/external'
if /bin/sh ../../../libtool --mode=compile gcc -DHAVE_CONFIG_H -I. -I. -I../../..  -I../../.. -I../../../gegl -I../../../gegl -I../../../gegl/buffer -I../../../gegl/buffer -I../../../
gegl/operation -I../../../gegl/operation -I../../../gegl/property-types -I../../../gegl/property-types -I../../../gegl/module -I../../../gegl/module   -O2 -g -pipe -Wall -Wp,-D_FORTIF
Y_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic -Wdeclaration-after-statement -Wmissing-prototypes -Wmissing-declarations -Winit-self -Wpointer
-arith -Wold-style-definition -mmmx -msse -MT gluas_la-gluas.lo -MD -MP -MF ".deps/gluas_la-gluas.Tpo" \
          -c -o gluas_la-gluas.lo `test -f 'gluas.c' || echo './'`gluas.c; \
        then mv -f ".deps/gluas_la-gluas.Tpo" ".deps/gluas_la-gluas.Plo"; \
        else rm -f ".deps/gluas_la-gluas.Tpo"; exit 1; \
        fi
libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I. -I../../.. -I../../.. -I../../../gegl -I../../../gegl -I../../../gegl/buffer -I../../../gegl/buffer -I../../../gegl/operation -I../../..
/gegl/operation -I../../../gegl/property-types -I../../../gegl/property-types -I../../../gegl/module -I../../../gegl/module -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fs
tack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic -Wdeclaration-after-statement -Wmissing-prototypes -Wmissing-declarations -Winit-self -Wpointer-arith -Wold-style-definiti
on -mmmx -msse -MT gluas_la-gluas.lo -MD -MP -MF .deps/gluas_la-gluas.Tpo -c gluas.c  -fPIC -DPIC -o .libs/gluas_la-gluas.o
gluas.c:20:28: error: glib/gi18n-lib.h: No such file or directory
[... followup errors snipped ...]

I'll attach a patch which fixes this error (missing glib2 include path) and similar ones for other files in the same directory.

BTW, is there a reason that gegl stays with interface version 0.0 instead of bumping this to 0.1 now?
Comment 1 Nils Philippsen 2009-07-03 13:49:58 UTC
Created attachment 137789 [details] [review]
Proposed patch which adds missing $(GLIB_CFLAGS), $(BABL_CFLAGS) to operations/workshop/external/Makefile.am
Comment 2 Martin Nordholts 2009-07-14 20:17:13 UTC
Thanks, pushed to master:

commit b5e6f4f1f9c5038050387898581884fe73b7dc0f
Author: Nils Philippsen <nils@redhat.com>
Date:   Fri Jul 3 15:04:12 2009 +0200

    Bug 587684 – building gegl fails in operations/workshop/external

    Add $(GLIB_CFLAGS), $(BABL_CFLAGS) where missing

 operations/workshop/external/Makefile.am |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)