After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 587584 - array subscript is above array bounds
array subscript is above array bounds
Status: RESOLVED OBSOLETE
Product: gnome-commander
Classification: Other
Component: application
1.2.x
Other All
: Normal normal
: 1.2.8
Assigned To: epiotr
epiotr
Depends on:
Blocks:
 
 
Reported: 2009-07-02 09:30 UTC by Bin Li
Modified: 2009-07-02 12:31 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Bin Li 2009-07-02 09:30:50 UTC 
Please describe the problem:
I just tried to build Factory package gnome-commander-1.2.7-8.9
and the build said

gnome-cmd-file-list.cc:1387:45: warning: array subscript is above array bounds

The source code is

    data.text[FILE_LIST_NUM_COLUMNS]  = NULL;

but

    gchar *text[FILE_LIST_NUM_COLUMNS];

Clearly broken code.  I agree with the compiler.  Suggest code rework.

Steps to reproduce:


Actual results:
Warning.

Expected results:
Suggest code rework.

Does this happen every time?
Yes.

Other information:
Comment 1 epiotr 2009-07-02 12:31:45 UTC 
The reported problem has been fixed in the latest release 1.2.8. Please use for building sources from http://ftp.gnome.org/pub/GNOME/sources/gnome-commander/1.2/gnome-commander-1.2.8.tar.bz2