After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 587368 - should use gtkbuilder rather than libglade
should use gtkbuilder rather than libglade
Status: RESOLVED FIXED
Product: nautilus-sendto
Classification: Applications
Component: general
1.1.x
Other Linux
: Normal enhancement
: ---
Assigned To: nautilus-sendto-maint
nautilus-sendto-maint
Depends on:
Blocks: 572883
 
 
Reported: 2009-06-29 21:36 UTC by Sebastien Bacher
Modified: 2009-07-30 16:16 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
use gtkbuilder rather than libglade (28.16 KB, patch)
2009-06-29 21:40 UTC, Sebastien Bacher
committed Details | Review
the corresponding gtkbuilder.ui (26.13 KB, application/octet-stream)
2009-06-29 21:41 UTC, Sebastien Bacher
  Details

Description Sebastien Bacher 2009-06-29 21:36:28 UTC
nautilus-sendto should use gtkbuilder rather than libglade
Comment 1 Sebastien Bacher 2009-06-29 21:40:48 UTC
Created attachment 137586 [details] [review]
use gtkbuilder rather than libglade
Comment 2 Sebastien Bacher 2009-06-29 21:41:43 UTC
Created attachment 137587 [details]
the corresponding gtkbuilder.ui

git diff didn't list the new .ui for some reason so adding it now there
Comment 3 Bastien Nocera 2009-07-29 15:30:31 UTC
git diff doesn't diff new files. Instead you should do a commit and use git format-patch (so I don't have to add committer details or commit message by hand).
Comment 4 Bastien Nocera 2009-07-29 15:43:37 UTC
I fixed that little snafu:
+    		g_warning ("Couldn't load builder file: s", error->message);


commit c7735102a4525c669cf06d3ed4521901961d940f
Author: Sebastien Bacher <seb128@ubuntu.com>
Date:   Wed Jul 29 16:40:43 2009 +0100

    Bug 587368 – should use gtkbuilder rather than libglade
    
    Remove libglade dependency and use libglade instead
Comment 5 Sebastien Bacher 2009-07-30 12:58:57 UTC
Thanks for catching the typo and for the git hints, the error is on http://library.gnome.org/devel/gtk/stable/gtk-migrating-GtkBuilder.html for the g_debug syntax, do you know how we can get the library documentation update or where to report bugs about that one?
Comment 6 Sebastien Bacher 2009-07-30 13:08:48 UTC
(the typo was in the gtk documentation and mclasen will fix it now)