After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 587264 - Cannot fetch CD metadata when DiscID matches multiple results
Cannot fetch CD metadata when DiscID matches multiple results
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: Importing
1.4.3
Other Linux
: Normal normal
: 1.x
Assigned To: Banshee Maintainers
Banshee Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-06-29 02:51 UTC by rlange
Modified: 2011-09-01 06:19 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description rlange 2009-06-29 02:51:40 UTC
I have been importing my CDs into Banshee on my new computer.  While it has worked correctly for most discs, some have either failed entirely to find CD metadata (i.e., Banshee reports it cannot find CD metadata) or spun for many minutes searching for the metadata until I finally gave up.

In all of the unsuccessful instances, I opened Sound Juicer and it found the CD metadata almost instantly.  Using Sound Juicer, I ripped the tracks to my Music library using the same artist, album, and track naming formats as Banshee.

Then I had Banshee rescan the library.  It identified the albums and downloaded the correct album cover graphics.  This fact tells me that, whatever music lookup service Banshee uses, it does know about these albums.

Some example albums that Banshee could not identify but Sound Juicer could:

Pink Floyd / Meddle    <- searched indefinitely
Pink FLoyd / Obscured by Clouds    <- failed
Led Zeppelin / In Through the Out Door    <- searched indefinitely

So far I have not found a single album that Sound Juicer cannot correctly identify, so perhaps you should consider using the lookup service that Sound Juicer uses for Banshee lookups.
Comment 1 Bertrand Lorentz 2009-06-29 18:25:55 UTC
I think Sound Juicer uses the same service as Banshee : MusicBrainz.

You're certainly hitting bug #527788, especially for the "spinning endlessly".
You might want to try the latest source from git.

Were you able to reproduce the failures repeatedly ?
All the errors I get are when MusicBrainz is overloaded and rejecting queries.
Comment 2 rlange 2009-07-01 02:05:36 UTC
Certain CDs seem to consistently fail, certain CDs seem to consistently spin, and the rest seem to consistently succeed.

I think I have figured out why some CDs fail outright.  I have observed this only for two Pink Floyd CDs, Obscured By Clouds and A Momentary Lapse of Reason.  When Banshee is started from the command line while Lapse is in the drive, I get this output:

-----

$ banshee
[Info  22:00:24.287] Running Banshee 1.4.3: [Ubuntu jaunty (development branch) (linux-gnu, i486) @ 2009-03-22 18:04:14 UTC]
[Info  22:00:27.488] Querying MusicBrainz for Disc Release (BHUkBKc.EqBygvKvyYYPwO96qHA-)
[Info  22:00:28.454] Query finished (success: False, 0.965378 seconds)
Mirage - Open DB - URI=file:/home/user/.cache/banshee-mirage/mirage.db,version=3
Mirage - Database version 2 is up to date
[Info  22:00:28.982] All services are started 4.232174s
[Info  22:00:30.871] nereid Client Started

-----

When I load Sound Juicer for either disc, it says that the disc may be one of two (or more) possible albums, and gives me the choice of which album it is.

Perhaps Banshee is not correctly handling it when MusicBrainz finds more than one possible album for a disc?
Comment 3 rlange 2009-07-01 02:16:12 UTC
As for the issue of some CDs spinning forever without finding metadata or failing to find metadata, I guess that does sound very much like bug #527788.  Still, I think the part about failing to find metadata for a disc which may be one of two or more albums makes this bug unique compared to that bug.
Comment 4 Paul Smith 2010-01-13 16:40:12 UTC
I agree, this bug bites me: when I put in CDs that have more than one possible entry, Banshee just ignores all entries and shows the CD as unknown, which is bogus.

I've tried Rhythmbox and others, and when they run across a CD that can match more than one possibility they pop up a window and ask which one to use.  Banshee just fails.

I guess I just have a number of CDs like this so I run into this all the time; it makes Banshee very hard for me to use.
Comment 5 Aurélien Mino 2010-06-04 14:21:58 UTC
Could someone rename this bug to "Banshee cannot fetch CD metadata when DiscID matches multiple results"?

It's confirmed by http://forums.musicbrainz.org/viewtopic.php?pid=10402#p10402

There are 2 issues in Banshee.AudioCd.AudioCdDiscModel.LoadDiscMetadata():
- Release release = Release.Query (mb_disc).PerfectMatch (); could return null if more than one MusicBrainz releases match this mb_disc but the code continues without checking the null value and this leads to a crash.
- As suggested, if multiple releases match, a pop up should ask the user to choose which one to use
Comment 6 Gabriel Burt 2010-06-04 18:22:34 UTC
Thanks for the info, Aurélien.
Comment 7 mdpoole 2011-03-01 04:48:11 UTC
I am being bitten by this bug in Banshee 1.9.4, and am willing to write code for it if someone can help point me in the right direction.  Once AudioCdDiscModel.LoadDiscMetadata() realizes that there are multiple "best" matches, should it just raise an event a la MetadataQueryStarted?  Would that then go through GlobalActions.cs to show a new dialog from the Banshee.Gui.Dialogs package, with the event handler having the chance to select the user-selected choice?
Comment 8 Aurélien Mino 2011-05-19 09:02:19 UTC
This issue will soon become really critical.
Indeed MusicBrainz just released a major new version, with some important data model changes.

One of this change is that we've moved: 
- from concentrating unique track listings into one release that has multiple CD TOCs attached (so most CD lookups returned only one result)
- to a model where each album issue is independent (e.g. US, UK, FR issues are distinct releases), and can have its own CD TOC (and DiscID), eventually shared by multiple releases. 

As a consequence many more CD lookups will have multiple matches.
Comment 9 Bertrand Lorentz 2011-05-28 14:49:29 UTC
This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.

I've just committed a fix for this problem, on git master and the stable-2.0 branch :

http://git.gnome.org/browse/banshee/commit/?id=ee467bdc

We now user the first release, if it has a score of 100.

If my understanding is correct, I don't think asking the user to choose between the various releases would be useful : we're mostly interested in basic metadata (like track title, artists, etc.) and those are probably (always ?) the same for all releases.
If that assumption is wrong, please file another bug for any issue it might cause.
Comment 10 Pavel Nazarov 2011-08-06 12:03:44 UTC
[Info  14:46:35.889] Querying MusicBrainz for Disc Release (zQ_MvajIbfOaxMSQMtUOVzd_JLY-)
[Info  14:46:36.676] Query finished (success: False, 0.786918 seconds)
[Info  14:47:53.830] Querying MusicBrainz for Disc Release (buDd54CW36ZDzehEv5Q_ZnKfDCk-)
[Info  14:47:54.377] Query finished (success: False, 0.546619 seconds)

while both disc ids are presented on MB.
Banshee 2.1.0
Comment 11 apfitch 2011-08-16 09:47:41 UTC
(In reply to comment #10)
> [Info  14:46:35.889] Querying MusicBrainz for Disc Release
> (zQ_MvajIbfOaxMSQMtUOVzd_JLY-)
> [Info  14:46:36.676] Query finished (success: False, 0.786918 seconds)
> [Info  14:47:53.830] Querying MusicBrainz for Disc Release
> (buDd54CW36ZDzehEv5Q_ZnKfDCk-)
> [Info  14:47:54.377] Query finished (success: False, 0.546619 seconds)
> 
> while both disc ids are presented on MB.
> Banshee 2.1.0

Hi Pavel,
  the fix above is dated 2011-05-28, and 2.1.0 was dated 2011-05-12, so perhaps the fix isn't in 2.1.0? I downloaded the source code and added the fix myself, and it worked,
Alan
Comment 12 Andrés G. Aragoneses (IRC: knocte) 2011-08-16 10:19:27 UTC
Exactly, the fix will be in 2.1.1 and 2.0.2.
Comment 13 Aurélien Mino 2011-09-01 06:19:03 UTC
For the record, I've created bug 651338 because I think this fix is really too simple and even wrong in some situations.