After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 587082 - v4lsrc should open/close the device in ready
v4lsrc should open/close the device in ready
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: 0.10.23
Assigned To: Stefan Sauer (gstreamer, gtkdoc dev)
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-06-26 18:15 UTC by Stefan Sauer (gstreamer, gtkdoc dev)
Modified: 2009-06-29 09:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
use state_change function to open/close device (4.48 KB, patch)
2009-06-26 18:16 UTC, Stefan Sauer (gstreamer, gtkdoc dev) 		committed Details | Review

Description Stefan Sauer (gstreamer, gtkdoc dev) 2009-06-26 18:15:07 UTC 
it opens/closes the device in basesrc::start/stop. This requires apps to set the element to paused to query settings and this causes it to start streaming (which is not very fast). Same thing was fixed for v4l2src recently.
Comment 1 Stefan Sauer (gstreamer, gtkdoc dev) 2009-06-26 18:16:18 UTC 
Created attachment 137438 [details] [review]
use state_change function to open/close device

only testsed a bit with libv4lcompat. Can someone with a real v4l device please test?
Comment 2 Filippo Argiolas 2009-06-27 07:00:31 UTC 
Works fine here with libv4l1compat with two different drivers (uvcvideo and gspca), I could try with gspcav1 but I'm not sure it's worth.
Since the patch is only affecting when the device is opened I think it's pretty safe to assume that it will work fine with pure v4l1 drivers too. I don't think you will have an easy time finding some v4l1 device to test it... There is even no test driver like vivi for v4l2.
Comment 3 Filippo Argiolas 2009-06-28 08:22:23 UTC 
Fixed?

commit b64be90326b28a0fccb2e356c112147776ea2572
Author: Stefan Kost <ensonic@users.sf.net>
Date:   Fri Jun 26 21:11:45 2009 +0300

    v4l: open/close device in ready.
    
    Simillar change like in v4l2src. This allows probing feature in paused, wher
    streaming is noit yet started.
Comment 4 Stefan Sauer (gstreamer, gtkdoc dev) 2009-06-29 09:28:44 UTC 
Thanks. Forgot the bug :)