After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 586965 - [dvdnav] Types declaration should be done at the beginning of the method
[dvdnav] Types declaration should be done at the beginning of the method
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-ugly
0.10.12
Other Windows
: Normal normal
: NONE
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-06-25 16:45 UTC by Andoni Morales
Modified: 2009-08-16 18:11 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fixes types declaration bug (3.02 KB, patch)
2009-06-25 16:46 UTC, Andoni Morales 		none Details | Review

Description Andoni Morales 2009-06-25 16:45:38 UTC 
The MSVC compiler doesn't allow to declare a type in the middle of a method and thus it should be done at the beginning.
This bug affects gst-plugins-bad/ext/dvdnav/dvdnavsrc.c
I attach the patch
Comment 1 Andoni Morales 2009-06-25 16:46:31 UTC 
Created attachment 137373 [details] [review]
Fixes types declaration bug
Comment 2 Sebastian Dröge (slomo) 2009-06-25 17:26:47 UTC 
The dvdnav element was more or less replaced by the resindvd element
Comment 3 Jan Schmidt 2009-06-26 11:01:26 UTC 
Personally, I think we should remove the dvdnav element. It requires hacking configure.ac and other things to even enable the build, and resindvd is mature enough that I think we could move it to -ugly soon.
Comment 4 Tim-Philipp Müller 2009-06-26 11:06:34 UTC 
> Personally, I think we should remove the dvdnav element. It requires hacking
> configure.ac and other things to even enable the build

+1
Comment 5 Sebastian Dröge (slomo) 2009-06-26 12:08:55 UTC 
Agreed
Comment 6 Thomas Green 2009-08-16 18:02:45 UTC 
This can be closed now that dvdnav is no more:

http://cgit.freedesktop.org/gstreamer/gst-plugins-ugly/commit/?id=f5d046a0b034f9bd7274291f7131ee5db1a30052
Comment 7 Tim-Philipp Müller 2009-08-16 18:11:30 UTC 
True, thanks for the tip.