GNOME Bugzilla – Bug 586894
distclean removes gst-libs/ext/ffmpeg
Last modified: 2009-10-05 14:29:51 UTC
"make distclean" removes subdirectory gst-libs/ext/ffmpeg, after which any subsequent attempt to configure/make fails with the make error: dtaylor@dtaylor-ubuntu:/work/gst-ffmpeg-0.10.7$ make Making all in gst-libs Making all in ext /bin/bash: line 0: cd: ffmpeg: No such file or directory make[4]: *** [all-local] Error 1 make[3]: *** [all-recursive] Error 1 make[2]: *** [all-recursive] Error 1 make[1]: *** [all-recursive] Error 1 make: *** [all] Error 2 dtaylor@dtaylor-ubuntu:/work/gst-ffmpeg-0.10.7$
That's because the ffmpeg directory is checked out when running autogen.sh Running "make distclean" implies you should run autogen.sh again (try it on any other gstreamer module and you'll have the same behaviour). Closing bug.
That's actually not true: make distclean should reset everything to tarball state, make maintainerclean should also remove the autoconf/automake generated files. For all other GStreamer modules this probably works as the Debian build bots will usually call make distclean before a build (and in the case of gst-ffmpeg it doesn't matter if the directory is there or not because of system ffmpeg being used)
I filed the bug because of the modules: gstreamer, gst-plugins-base, gst-plugins-good, gst-plugins-bad, gst-plugins-ugly, and gst-ffmpeg, ONLY gst-ffmpeg does not configure/make after a distclean, therefore EH's comments are incorrect. All of them have been downloaded as latest tarballs (except the just-announced pre-release of ffmpeg). I do not want to start a food fight, but this behavior is inconsistent with the other tarball releases, and should be changed.
Then it's a new behaviour. I never expected anything to work between 'make distclean' and 'autogen.sh'. Patch welcome to fix this.
AFAIK this was always the expected behaviour (but many build systems removed too much in distclean). I'll make a patch tomorrow or Monday if nobody is faster, this will then remove the ffmpeg directory on maintainerclean only.
Created attachment 141152 [details] [review] Patch to remove gst-libs/ext/ffmpeg in maintainerclean target only
commit 9beafa7eace1ffb5a890e9ba0b7c48a61d48e72e Author: Jarkko Palviainen <jarkko.palviainen@sesca.com> Date: Wed Aug 19 15:28:35 2009 +0200 build: Remove gst-libs/ext/ffmpeg in maintainerclean target only Fixes bug #586894.
This change actually breaks the distcheck target by no longer cleaning anything in the ffmpeg snapshot subdirectory during distclean. Fix in this commit by making sure to call the ffmpeg distclean target: commit a472d1c2266df0ca4c01d0d25fb39b99248c7995 Author: Jan Schmidt <thaytan@noraisin.net> Date: Mon Oct 5 15:28:33 2009 +0100 Fix distclean/distcheck