After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 586873 - PTS produced by gstffmpegmux are not DVD compatible
PTS produced by gstffmpegmux are not DVD compatible
Status: RESOLVED NOTABUG
Product: GStreamer
Classification: Platform
Component: gst-libav
git master
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-06-24 18:23 UTC by Jordi Mas
Modified: 2009-06-26 18:23 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed patch (2.46 KB, patch)
2009-06-24 18:24 UTC, Jordi Mas
needs-work Details | Review

Description Jordi Mas 2009-06-24 18:23:29 UTC
Hello,

PTS (presentation time stamp) produced by gstffmpegmux is not DVD compatible. Some of the MPEG produced cannot be played in regular DVDs players. This is caused because PTS for DVD have to be rounded to certain values.

In order to fix this, a new element name called "ptsrounding" has been introduced that can be used when calling the muxer to make sure that the PTS are DVD compatible.

Attached you have a proposed patch

Regards,

Jordi,
Comment 1 Jordi Mas 2009-06-24 18:24:36 UTC
Created attachment 137330 [details] [review]
Proposed patch
Comment 2 Edward Hervey 2009-06-25 09:58:01 UTC
Several things wrong with the patch itself:
* What's the unit of the property (nanoseconds ? milliseconds ? bananas per square foot ?)
* allowing zero will result in big problems since you're using it as the denominator of a division
* What rounding value should be used for the dvd case ?

That being said... isn't the problem with the upstream encoders providing non-rounded timestamps ?
Comment 3 Jan Schmidt 2009-06-25 10:02:50 UTC
Also, do you have a reference for the feature? The only limitation I know of on PTS for DVD is that they need to be less than 0xffffffff, to match with the SCR that is duplicated as a 32-bit int in each NAV packet.
Comment 4 Jordi Mas 2009-06-25 11:14:34 UTC
Edward,

· The value of PTS is specified in units of the period of the system clock
frequency divided by 300 (yielding 90 kHz).
· Regarding allowing 0, you're right, the interval should start at 1.
· In DVD case, the rounding value that I found that works is 300.

Jan,

No, unfortunately I have no documentation for this feature. I only have found that some software[1] do comment in their source code.

As you know, there is little documentation of the MPEG/DVD. I found this value by experimentation. Jan, if you can point to some documentation I will appreciate it.

Regards,

Jordi,


[1] http://www.google.com/codesearch/p?hl=en&sa=N&cd=1&ct=rc#_j9QLhFEGhM/lxdvdrip/dvdauthor/0.6.12-2992alpha/dvdvob.c&q=dvdauthor%20%22Video%20PTS%20does%20not%20line%20up%20on%20a%20multiple%20of%20a%20field%22&l=56
Comment 5 Jordi Mas 2009-06-26 18:22:03 UTC
I have been looking at the ffmpeg source code more closely and I have found that using the preload parameter I can fix this issue.

Sorry about the confusion. I should look into this better.

Regards,

Jordi,