GNOME Bugzilla – Bug 586851
Transparent BMP files fail to load
Last modified: 2009-07-22 16:24:53 UTC
BMP files with an alpha component fail to load and produce an error message.
Created attachment 137317 [details] Example BMP file that causes failure
I can confirm this.
Created attachment 138984 [details] [review] Patch for release 2.6.6 The attached patch all else failing, before giving up, calls 'gdk_pixbuf_new_from_file'. With a recent version of gtk I'm able to load the file attached to comment #1. Patch against file 'plug-ins/file-bmp/bmp-read.c' of release 2.6.6. HTH
Thanks, pushed to master and gimp-2-6 after removing trailing whitespace: commit 61db48ac746e1b609dae3072d7fc0b702f1ff70d Author: Massimo Valentini <sixtysix@inwind.it> Date: Wed Jul 22 18:17:00 2009 +0200 Bug 586851 – Transparent BMP files fail to load If everything else fails, use gdk_pixbuf_new_from_file(). plug-ins/file-bmp/bmp-read.c | 35 +++++++++++++++++++++++++++++++---- 1 files changed, 31 insertions(+), 4 deletions(-)
If gdk_pixbuf_new_from_file() is used as a fallback anyway, why not then call *only* that in the plug-in? That way the code for reading BMP would be in just one place. Hmm, except that there presumably are some kinds of BMPs that the plug-in's own code reads differently from gdk-pixbuf's code.
That would be too high risk for 2.6 I would welcome that change in the master branch though