GNOME Bugzilla – Bug 586846
Remove deprecated libgnomeui dependency
Last modified: 2010-01-12 22:05:17 UTC
See http://live.gnome.org/LibgnomeMustDie . For API reference see http://library.gnome.org . ./gnome-panel/main.c: #include <libgnomeui/gnome-client.h> ./gnome-panel/panel-session.c: #include <libgnomeui/gnome-client.h> ./gnome-panel/panel-session.c: * TODO: when migrating away from libgnomeui, we need to keep this ./gnome-panel/main.c: #include <libgnomeui/gnome-ui-init.h> ./gnome-panel/gnome-desktop-item-edit.c: #include <libgnomeui/gnome-ui-init.h> ./gnome-panel/panel-run-dialog.c: #include <libgnomeui/gnome-entry.h> ./gnome-panel/panel-ditem-editor.c: #include <libgnomeui/gnome-icon-entry.h> ./gnome-panel/panel-properties-dialog.c: #include <libgnomeui/gnome-icon-entry.h> ./configure.in:PKG_CHECK_MODULES(PANEL, ORBit-2.0 >= $ORBIT_REQUIRED gdk-pixbuf-2.0 >= $GDK_PIXBUF_REQUIRED pango >= $PANGO_REQUIRED gtk+-2.0 >= $GTK_REQUIRED glib-2.0 >= $GLIB_REQUIRED gio-2.0 >= $GLIB_REQUIRED gio-unix-2.0 >= $GLIB_REQUIRED libgnome-2.0 >= $LIBGNOME_REQUIRED libgnomeui-2.0 >= $LIBGNOMEUI_REQUIRED libbonoboui-2.0 >= $LIBBONOBOUI_REQUIRED gnome-desktop-2.0 >= $LIBGNOME_DESKTOP_REQUIRED libglade-2.0 >= $LIBGLADE_REQUIRED gconf-2.0 >= $GCONF_REQUIRED libgnome-menu >= $LIBGNOME_MENU_REQUIRED dbus-glib-1 >= $DBUS_GLIB_REQUIRED)
./gnome-panel/main.c: #include <libgnomeui/gnome-client.h> ./gnome-panel/panel-session.c: #include <libgnomeui/gnome-client.h> ./gnome-panel/panel-session.c: * TODO: when migrating away from libgnomeui, we need to keep this ./gnome-panel/main.c: #include <libgnomeui/gnome-ui-init.h> program = gnome_program_init ("gnome-panel", VERSION, ./gnome-panel/gnome-desktop-item-edit.c: #include <libgnomeui/gnome-ui-init.h> program = gnome_program_init ("gnome-desktop-item-edit", VERSION, ./gnome-panel/panel-run-dialog.c: #include <libgnomeui/gnome-entry.h> gnome_entry_prepend_history (GNOME_ENTRY (dialog->gnome_entry), TRUE, /* save item in history */ command); dialog->gnome_entry = glade_xml_get_widget (gui, "gnome_entry"); g_object_set (G_OBJECT (dialog->gnome_entry), ./gnome-panel/panel-ditem-editor.c: #include <libgnomeui/gnome-icon-entry.h> priv->icon_entry = gnome_icon_entry_new ("desktop-icon", _("Browse icons")); file = gnome_icon_entry_get_filename (GNOME_ICON_ENTRY (dialog->priv->icon_entry)); gnome_icon_entry_set_filename (GNOME_ICON_ENTRY (dialog->priv->icon_entry), tmpstr); ./gnome-panel/panel-properties-dialog.c: #include <libgnomeui/gnome-icon-entry.h> static void panel_properties_dialog_icon_changed (PanelPropertiesDialog *dialog, GnomeIconEntry *entry) icon = gnome_icon_entry_get_filename (entry); gnome_icon_entry_set_filename (GNOME_ICON_ENTRY (dialog->icon_entry), custom_icon);
./gnome-panel/panel-run-dialog.c: #include <libgnomeui/gnome-entry.h> is covered by bug 576916.
So, the big issue here is GnomeIconEntry. We have nothing to replace this :/
(In reply to comment #3) > So, the big issue here is GnomeIconEntry. We have nothing to replace this :/ Solution from anjuta developers: "- I have replaced the GnomeIconEntry with a GtkButton displaying an image and calling a file browser dialog" See http://bugzilla.gnome.org/show_bug.cgi?id=513156#c88
vuntz: ping
So, current to-do status on git master of gnome-panel: ./gnome-panel/main.c:#include <libgnomeui/gnome-client.h> ./gnome-panel/panel-session.c:#include <libgnomeui/gnome-client.h> See http://live.gnome.org/SessionManagement/EggSMClient For porting examples, see http://git.gnome.org/browse/gok/commit/?h=gnome-2-28&id=c10c6584449e644173fe738f99f3416bce6d17dc http://git.gnome.org/browse/yelp/commit/?id=0f4c349586749b6dc04065426e0d5355b704c6cf ./gnome-panel/main.c:#include <libgnomeui/gnome-ui-init.h> ./gnome-panel/gnome-desktop-item-edit.c:#include <libgnomeui/gnome-ui-init.h> For porting examples, see http://git.gnome.org/browse/yelp/commit/?id=0f4c349586749b6dc04065426e0d5355b704c6cf http://git.gnome.org/browse/gtkhtml/commit/?id=bcf04302751e46b377ca91c7cdd02dbce95d8929 ./gnome-panel/nothing.cP:#include <libgnome/gnome-program.h> ./gnome-panel/nothing.cP:#include <libgnome/gnome-sound.h> ./gnome-panel/panel-ditem-editor.c:#include <libgnomeui/gnome-icon-entry.h> ./gnome-panel/panel-properties-dialog.c:#include <libgnomeui/gnome-icon-entry.h> For an idea how to port this, see http://git.gnome.org/browse/anjuta/commit/?h=gnome-2-28&id=6b663ab536d1b7355963ddbf414c8ae86c8515d2 Any volunteers around for providing patches?
Created attachment 150952 [details] [review] Remove libgnomeui/gnome-ui-init.h dependency.First patch This patch removes libgnomeui/gnome-ui-init.h dependency from gnome-panel/gnome-desktop-item-edit.c file. I have another patch for gnome-panel/main.c but there is a problem: panel_cleanup_register() needs a GnomeProgram variable, how can I solve this?
The problem with the patch is that some code used by gnome-desktop-item-edit uses libgnomeui API, so we still require gnome_program until this code is removed. But I'll do it right now.
Comment on attachment 150952 [details] [review] Remove libgnomeui/gnome-ui-init.h dependency.First patch I've committed this now, since I've removed part of the code using libgnomeui that was requiring this.
And I got rid of the rest of libgnome* code in gnome-panel. Here we go :-)