After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 586356 - [playbin2] use private copy of input-selector as long as it's still in -bad
[playbin2] use private copy of input-selector as long as it's still in -bad
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal blocker
: 0.10.24
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-06-19 10:16 UTC by Bastien Nocera
Modified: 2009-07-15 16:48 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
playbin2: add private copy of input-selector (could use some testing) (49.97 KB, patch)
2009-07-15 01:34 UTC, Tim-Philipp Müller
committed Details | Review

Description Bastien Nocera 2009-06-19 10:16:23 UTC
playbin2 needs input-selector, so it should be moved to live with playbin2 itself.
Comment 1 Tim-Philipp Müller 2009-07-15 01:34:54 UTC
Created attachment 138420 [details] [review]
playbin2: add private copy of input-selector (could use some testing)
Comment 2 Jan Schmidt 2009-07-15 12:43:37 UTC
please commit
Comment 3 Tim-Philipp Müller 2009-07-15 16:48:57 UTC
Pushed as two separate commits, so the local changes to the input selector are more obvious.

commit 5366b61bfc305eae504e8ea6a0df3201e563f68f
Author: Tim-Philipp Müller <tim.muller@collabora.co.uk>
Date:   Wed Jul 15 17:40:14 2009 +0100

    playbin2: use private copy of input-selector
    
    We shouldn't really depend on elements from -bad for stream
    selection in playbin2, so use a private copy of input-selector
    until the selector plugin is ready to be moved to -base or -good.
    Fixes #586356.

commit e1df8d0691fd7f2cfbd60a01119eaeb6035fdf53
Author: Tim-Philipp Müller <tim.muller@collabora.co.uk>
Date:   Wed Jul 15 17:26:32 2009 +0100

    playback: add private copy of the input-selector from gst-plugins-bad
    
    Not hooked up yet though. See #586356.