After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 585887 - "Publish my location" causes a crash
"Publish my location" causes a crash
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Geolocation
2.27.x
Other All
: Normal critical
: ---
Assigned To: empathy-maint
Depends on:
Blocks:
 
 
Reported: 2009-06-15 16:50 UTC by Nicolò Chieffo
Modified: 2009-06-17 17:29 UTC
See Also:
GNOME target: ---
GNOME version: 2.27/2.28


Attachments
Fix on branch fix-geoclue-init http://git.collabora.co.uk/?p=user/pierlux/empathy.git;a=shortlog;h=refs/heads/fix-geoclue-init (1.43 KB, patch)
2009-06-15 20:35 UTC, Pierre-Luc Beaudoin
accepted-commit_now Details | Review

Description Nicolò Chieffo 2009-06-15 16:50:37 UTC
Steps to reproduce:
1. edit
2. preferences
3. location
4. public my location
= crash!


Stack trace:

Thread 1 (Thread 0x7f27a4d5e810 (LWP 777))

  • #0 geoclue_master_client_set_requirements
    from /usr/lib/libgeoclue.so.0
  • #1 update_resources
    at empathy-location-manager.c line 458
  • #2 publish_cb
    at empathy-location-manager.c line 488
  • #3 g_type_create_instance
    from /usr/lib/libgobject-2.0.so.0
  • #4 ??
    from /usr/lib/libgobject-2.0.so.0
  • #5 location_manager_constructor
    at empathy-location-manager.c line 84
  • #6 g_object_newv
    from /usr/lib/libgobject-2.0.so.0
  • #7 g_object_new_valist
    from /usr/lib/libgobject-2.0.so.0
  • #8 g_object_new
    from /usr/lib/libgobject-2.0.so.0
  • #9 empathy_location_manager_dup_singleton
    at empathy-location-manager.c line 666
  • #10 main
    at empathy.c line 626


Other information:
libgeoclue 0.11.1-3 (no -dbg is installable)
Comment 1 Pierre-Luc Beaudoin 2009-06-15 19:30:59 UTC
This stack trace is not helping very much.  Could you try reproducing it again and include the segfault messages? Also, is there any messages printed on the console before the crash?
Comment 2 Nicolò Chieffo 2009-06-15 19:34:51 UTC
Here's the only thing that I see in the console (I call empathy through run.sh)
(empathy:5295): GLib-GObject-CRITICAL **: g_type_instance_get_private: assertion `instance != NULL && instance->g_class != NULL' failed
./run.sh: line 22:  5295 Segmentation fault      ./install/bin/empathy
Comment 3 Pierre-Luc Beaudoin 2009-06-15 20:03:28 UTC
Ok, I found a place where Empathy could crash if Dbus fails to connect to the geoclue service. Is you geoclue setup working with other applications?

In the mean time, I'll submit a patch to empathy.
Comment 4 Nicolò Chieffo 2009-06-15 20:12:12 UTC
Well, I don't know. I've just installed it. can you point me to a test I can do? (also a piece of code if you want)
Comment 5 Pierre-Luc Beaudoin 2009-06-15 20:18:37 UTC
If you built geoclue, there is an example folder.  If not, you can have a try at http://git.gnome.org/cgit/geoclue-properties/ but it isn't installable for now.
Comment 6 Nicolò Chieffo 2009-06-15 20:26:14 UTC
I've found the trick: it needs the "geoclue" package (not only libgeoclue)
For sure the crash was the dbus service check!
Don't forget to add a dialog to explain what's happening.

I've a question: how can I use geolocation?
I've enabled network usage and I'm connected to MSN, what will other users see? and how can I see where are other people located?
Comment 7 Pierre-Luc Beaudoin 2009-06-15 20:28:33 UTC
See the Geolocation section on http://live.gnome.org/Empathy/FAQ :)

As for what will the other see, there bug 584234 and 584519 will address that by giving more feedback.
Comment 8 Pierre-Luc Beaudoin 2009-06-15 20:35:10 UTC
Created attachment 136665 [details] [review]
Fix on branch fix-geoclue-init http://git.collabora.co.uk/?p=user/pierlux/empathy.git;a=shortlog;h=refs/heads/fix-geoclue-init

 libempathy-gtk/empathy-location-manager.c |   15 +++++++++++----
 1 files changed, 11 insertions(+), 4 deletions(-)
Comment 9 Guillaume Desmottes 2009-06-16 09:34:32 UTC
Looks good.
Comment 10 Pierre-Luc Beaudoin 2009-06-17 16:08:59 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Comment 11 Nicolò Chieffo 2009-06-17 16:40:56 UTC
With this patch, whenever I start empathy I get a geoclue crash. (also when I disable and re-enable location support from the preferences dialog)

Here's the link with debugging information https://bugs.launchpad.net/ubuntu/+source/geoclue/+bug/388549
Comment 12 Pierre-Luc Beaudoin 2009-06-17 16:50:13 UTC
I am getting
Not allowed here
Sorry, you don't have permission to access this page.
You are logged in as Pierre-Luc Beaudoin. 

Can you put that info somewhere really public? :)
Comment 13 Nicolò Chieffo 2009-06-17 17:00:30 UTC
Do you mean that you can't view launchpad pages?
can you see this file?
http://launchpadlibrarian.net/28033111/Stacktrace.txt

anyway I suspect that it is a geoclue problem
Comment 14 Pierre-Luc Beaudoin 2009-06-17 17:29:18 UTC
Yes I can. It is definitively a Geoclue bug.  You can fill it on bugs.freedesktop.org.