GNOME Bugzilla – Bug 585845
0.10.7.2 breaks swfdec
Last modified: 2009-06-25 15:27:56 UTC
gst-ffmpeg 0.10.7.2 breaks swfdec when it comes to playing back videos on YouTube. As far as I can tell, it happens with all videos, and possibly on other sites than YouTube as well. swfdec prints this error message, before hanging the browser: SWFDEC: ERROR: swfdec_video_decoder_gst.c(156): swfdec_video_decoder_gst_decode: failed to pull decoded buffer. Broken stream? Downgrading to 0.10.7 solves this problem.
Marking as blocker for now.
It broke with this commit: commit a26b94d92c2e9e9f6dac0cdb5fb44ba06ee089c8 Author: Vanista <vanista@gmail.com> Date: Wed May 13 12:37:42 2009 +0200 gstffmpegdec: Handle out-of-order frames. Fixes #580796 Not sure why yet.
Created attachment 136880 [details] [review] proposed patch to fix gst-ffmpeg timestamp tracking This patch fixes an infinite loop in the gst_ts_handler_consume() function when no buffer sizes have been stored into the timestamp arrays - which happened when all incoming timestamps (so far) are -1
Vanista, can you confirm things still work for you with this patch?
In the absence of commentary, I pushed the patch to git. Edward said he'll do some testing today, then I'll make a new gst-ffmpeg pre-release so the release is not held up much longer.
I'm using this patch since some time now and the Debian/experimental package also includes it and it fixes the swfdec breakage and doesn't seem to break anything new... but I didn't explicitly test it on out-of-order frames.
Hi, sorry for the delay, I've been pretty busy lately. I just tested the latest fix and everything look good with my samples! Also, simply looking at the fix now, I know it's valid, my original condition was definitely faulty. Thanks for supporting my solution.
Thanks for confirming