After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 585843 - Should use stable Geolocation API
Should use stable Geolocation API
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Geolocation
unspecified
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
Depends on:
Blocks:
 
 
Reported: 2009-06-15 12:01 UTC by Guillaume Desmottes
Modified: 2009-08-17 10:20 UTC
See Also:
GNOME target: 2.28.x
GNOME version: ---


Attachments
Undrafted and use tp-glib API http://git.collabora.co.uk/?p=user/cassidy/empathy;a=shortlog;h=refs/heads/undraft-location (17.95 KB, patch)
2009-08-17 10:15 UTC, Guillaume Desmottes
committed Details | Review

Description Guillaume Desmottes 2009-06-15 12:01:55 UTC
We don't want to have a stable Empathy version depending on a DRAFT Telepathy API. The Location interface should be undrafted and Empathy should use it for 2.28.
Comment 1 André Klapper 2009-06-23 12:12:12 UTC
API/ABI Freeze for 2.27.x is on July 20th.
Comment 2 Pierre-Luc Beaudoin 2009-06-23 12:32:13 UTC
The changes to be added in the Telepathy-spec for geolocation should be API and ABI compatible (add a new key to the a{sv}).

I'll propose that change today.
Comment 3 Pierre-Luc Beaudoin 2009-06-26 02:24:23 UTC
Changes proposed to be reviewed during the next telepathy-spec meeting.
Comment 4 Sjoerd Simons 2009-07-14 11:19:28 UTC
(In reply to comment #1)
> API/ABI Freeze for 2.27.x is on July 20th.

Empathy is not a platform library so this doesn't apply
Comment 5 Guillaume Desmottes 2009-08-17 09:31:12 UTC
Location has been undrafted in the 0.17.27 version of the spec and the future
version of Gabble (0.7.33) will implement the stable API.
Comment 6 Guillaume Desmottes 2009-08-17 10:15:10 UTC
Created attachment 140952 [details] [review]
Undrafted and use tp-glib API http://git.collabora.co.uk/?p=user/cassidy/empathy;a=shortlog;h=refs/heads/undraft-location

 configure.ac                                 |    2 +-
 extensions/Connection_Interface_Location.xml |  330 --------------------------
 extensions/Makefile.am                       |    1 -
 extensions/misc.xml                          |    1 -
 libempathy/empathy-tp-contact-factory.c      |   14 +-
 5 files changed, 8 insertions(+), 340 deletions(-)
Comment 7 Guillaume Desmottes 2009-08-17 10:20:44 UTC
Merged to master. Thanks to Xavier for the review.