After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 585667 - Mis-passed SM and ICE flags
Mis-passed SM and ICE flags
Status: RESOLVED FIXED
Product: gnome-session
Classification: Core
Component: general
2.26.x
Other Mac OS
: Normal normal
: ---
Assigned To: Session Maintainers
Session Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-06-13 18:12 UTC by Daniel Macks
Modified: 2009-06-29 21:04 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Pass -I to compiler (518 bytes, patch)
2009-06-13 18:16 UTC, Daniel Macks 		none Details | Review

Description Daniel Macks 2009-06-13 18:12:35 UTC 
Building gnome-session-2.26.1 fails in the egg/ subdir for me because the -I flags for sm and ice are not used. Problem is that the -l and -L flags are passed instead of the -I ones during the .c->.o compile stage. Easy bug in egg/Makefile.am:

>INCLUDES = \
>	-DG_LOG_DOMAIN=\""EggSMClient"\" \
>	$(platform_defines)              \
>	$(EGG_SMCLIENT_CFLAGS)           \
>	$(SM_LIBS)			 \
>	$(ICE_LIBS)			 \
>	$(WARN_CFLAGS)			 \
>	$(DISABLE_DEPRECATED_CFLAGS)

yup, _LIBS are not INLCUDES flags, but _CFLAGS are.
Comment 1 Daniel Macks 2009-06-13 18:16:59 UTC 
Created attachment 136513 [details] [review]
Pass -I to compiler
Comment 2 Vincent Untz 2009-06-29 21:04:24 UTC 
Thanks. The LIBS variables actually needed to be moved to the right place.