After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 585660 - segfault in scaletempo plugin
segfault in scaletempo plugin
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal major
: 0.10.13
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-06-13 16:20 UTC by pbmaxi
Modified: 2009-06-14 18:02 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description pbmaxi 2009-06-13 16:20:19 UTC 
scaletempo plugin segfaults on some machines when playing at rates other than 1.0:

http://sourceforge.net/tracker/?func=detail&aid=2104199&group_id=220192&atid=1048723

Line 233 in gstscaletempo.c (http://cgit.freedesktop.org/gstreamer/gst-plugins-bad/tree/gst/scaletempo/gstscaletempo.c#n233) must be changed from

i = -(p->samples_overlap - p->samples_per_frame);

to

i = -((glong)p->samples_overlap - (glong)p->samples_per_frame);

Otherwise i won't be a negative number as intended. This is because p->samples_overlap and p->samples_per_frame are both unsigned.
Comment 1 Sebastian Dröge (slomo) 2009-06-14 18:02:11 UTC 
commit f0db7a4d6812eeeb88a8631333dca43d5697fd4c
Author: Maximilian Högner <pbmaxi@hoegners.de>
Date:   Sun Jun 14 20:00:51 2009 +0200

    scaletempo: Explicitely cast to signed integers to fix a segfault
    
    Fixes bug #585660.


I'll push this after gst-plugins-bad is open for commits again.