GNOME Bugzilla – Bug 585528
Use bookmark icon from theme
Last modified: 2012-08-11 17:24:06 UTC
Epiphany could use the bookmark icon from the icon theme instead of the copy it currently ships itself.
Created attachment 136394 [details] [review] Patch Found this old patch while cleaning up my HDD, looks like I never filed a bug for this but the patch still seems to apply.
Makes sense if they are identical. Please apply to trunk (and remember to remove the actual icon files). Thanks!
They are not 100% the same, the icon currently in g-i-t is misisng the gray bar on the left of the icon. You can see it in use in Panel->Places->Bookmarks (if you have >5 or so bookmarks). This also matches the "Add bookmark" icon used in Epiphany (which seems to be pulled from the theme already).
Created attachment 153426 [details] Comparison of icons I don't think there's a big difference. But the extra boldiness makes me think of "book" while the other on "page"
To me the user-bookmarks icon from the theme feels wrong because it represents "one bookmark", being a single page, not "many bookmarks" like a book.
Created attachment 153433 [details] [review] Don't use a custom icon for bookmark editor Bug #585528 -- Updated patch, also removes data/art/ dir and uses the stock icon for the .desktop file.
Mmm. I think I will end up agreeing with Chrisitan... the patch would still hold for the .desktop file though.
Created attachment 153921 [details] New user-bookmarks icon The new gnome-icon-theme now has a new user-bookmarks icon which is totally different... opinions welcome I guess...
In principle, I like this one. It conveys the idea of a "bookmark folder". The only point of criticism I have is that until now, a star-shape is used nowhere in Gnome to refer to a bookmark (as far as I know).
Was the "add bookmark" icon changed as well? To me it looks like a "personal folder" icon now, something in the spirit of "download folder" and "desktop folder". The relation to "add bookmark" is gone and it doesn't resemble a traditional bookmark at all anymore.
Created attachment 153925 [details] New bookmark-new icon Yes the bookmark-new icon was changed as well. I also feel we should only use one metaphor... Going for "star" has the benefit of matching about any other web browser out there (at least firefox, chrome, IE). Having bookmarks-new as a real bookmark at the same time does not make much sense however. Suggestions?
Comment on attachment 153433 [details] [review] Don't use a custom icon for bookmark editor This is obsolete.