After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 585433 - [queue] Can lock down if min-threshold conflicts with max-size
[queue] Can lock down if min-threshold conflicts with max-size
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other All
: Normal normal
: 0.10.24
Assigned To: Wim Taymans
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-06-11 12:59 UTC by Arnout Vandecappelle
Modified: 2009-06-15 17:07 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[queue] Don't lock when min-threshold and max-size conflict. (1.71 KB, patch)
2009-06-11 13:03 UTC, Arnout Vandecappelle 		committed Details | Review

Description Arnout Vandecappelle 2009-06-11 12:59:00 UTC 
When both min-threshold and max-size properties are set on a queue, it is possible that it locks down completely: nothing can be pushed into it because it is full, but also nothing is pushed out because it is simultaneously empty.

Patch follows.
Comment 1 Arnout Vandecappelle 2009-06-11 13:03:06 UTC 
Created attachment 136335 [details] [review]
[queue] Don't lock when min-threshold and max-size conflict.

When min-threshold is set on a queue, it is possible that one of
the minima remains unsatisfied while one of the maxima is already
reached. Therefore, always consider the queue non-empty if it is full.
Comment 2 Wim Taymans 2009-06-15 17:07:08 UTC 
commit 34aeb8ba7efd6c39d85b7172201bdd19008d6133
Author: Arnout Vandecappelle <arnout@mind.be>
Date:   Thu Jun 11 15:00:52 2009 +0200

    don't lock when min-threshold and max-size conflict.
    
    When min-threshold is set on a queue, it is possible that one of
    the minima remains unsatisfied while one of the maxima is already
    reached. Therefore, always consider the queue non-empty if it is full.
    
    Fixes #585433.