Created attachment 136286 [details] [review]
Four more tests

Comment on attachment 136286 [details] [review]
Four more tests

>diff --git a/gir/everything.c b/gir/everything.c

>+/**
>+ * test_utf8_const_in_out:
>+ * @out: (out):
>+ */
>+void
>+test_utf8_const_in_out (const char *in, char **out)
>+{
>+  *out = g_strdup (in);
>+}

needs transfer and docs.

>+
>+/**
>+ * test_utf8_out_const_in:
>+ * @out: (out):
>+ */
>+void
>+test_utf8_out_const_in (char **out, const char *in)
>+{
>+  (in, out);
>+}

no real reason to call test_utf8_const_in_out, just duplicate.
also missing transfer and doc.

>+/* multiple output arguments */
>+
>+/**
>+ * test_utf8_out_out:
>+ * @out0: (out):
>+ * @out1: (out):
>+ */
>+void
>+test_utf8_out_out (char **out0, char **out1)

>+char *
>+test_utf8_out_nonconst_return (char **out)

ditto.

Docs in the everything module/typelib is intended for the
bindngs author, to know how/what to test.

Created attachment 136329 [details] [review]
Two tests with annotations and documentation

Comment on attachment 136329 [details] [review]
Two tests with annotations and documentation

Looks great, thanks.

Broke 'make check' since you didn't add the extra tests to ./gir/Everything-1.0-expected.gir =(

[Mass-moving gobject-introspection tickets to its own Bugzilla product - see bug 708029. Mass-filter your bugmail for this message: introspection20150207 ]