After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 585178 - Style trouble with operator.xls
Style trouble with operator.xls
Status: RESOLVED FIXED
Product: Gnumeric
Classification: Applications
Component: General
git master
Other All
: Urgent major
: ---
Assigned To: Jody Goldberg
Jody Goldberg
Depends on:
Blocks:
 
 
Reported: 2009-06-08 18:12 UTC by sum1
Modified: 2009-06-09 13:10 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description sum1 2009-06-08 18:12:37 UTC
Steps to reproduce:
- ssconvert gnumeric/samples/excel/operator.xls /tmp/foo.xls


Console output (truncated):

WARNING **: Can't find style 0xa060578 for cell GT!?
WARNING **: Can't find style 0xa0606e8 for cell GT!D3
WARNING **: Can't find style 0xa0607a0 for cell GT!E3
WARNING **: Can't find style 0xa060858 for cell GT!F3
WARNING **: Can't find style 0xa060910 for cell GT!G3
WARNING **: Can't find style 0xa0609c8 for cell GT!H3


Backtrace:

  • #0 IA__g_log
    at /build/buildd/glib2.0-2.20.1/glib/gmessages.c line 522
  • #1 excel_sheet_write_block
    at ms-excel-write.c line 4758
  • #2 excel_write_sheet
    at ms-excel-write.c line 4963
  • #3 excel_write_workbook
    at ms-excel-write.c line 5718
  • #4 excel_write_v8
    at ms-excel-write.c line 5771
  • #5 excel_save
    at boot.c line 273
  • #6 excel_biff8_file_save
    at boot.c line 314
  • #7 go_plugin_loader_module_func_file_save
    at go-plugin-loader-module.c line 323
  • #8 go_plugin_file_saver_save
    at go-plugin-service.c line 749
  • #9 go_file_saver_save
    at file.c line 705
  • #10 wbv_save_to_output
    at workbook-view.c line 967
  • #11 wb_view_save_to_uri
    at workbook-view.c line 1004
  • #12 wb_view_save_as
    at workbook-view.c line 1040
  • #13 convert
    at ssconvert.c line 541
  • #14 main
    at ssconvert.c line 608

Comment 1 Morten Welinder 2009-06-08 20:24:55 UTC
Adding GNM_DEBUG=style-optimize:style-optimize-verify prduces:

[...]
Optimizing GT
Turning I17:P32 (8x16) from a matrix into a row
Turning I33:P48 (8x16) from a matrix into a row
Turning A49:H64 (8x16) from a matrix into a col
Turning I49:P64 (8x16) from a matrix into a simple
Turning Q49:X64 (8x16) from a matrix into a col
Turning I65:P80 (8x16) from a matrix into a row
Turning A4097:IV8192 (256x4096) from a ptr-matrix into a col
Turning A8193:IV12288 (256x4096) from a ptr-matrix into a col
Turning A12289:IV16384 (256x4096) from a ptr-matrix into a col
Turning A16385:IV20480 (256x4096) from a ptr-matrix into a col
Turning A20481:IV24576 (256x4096) from a ptr-matrix into a col
Turning A24577:IV28672 (256x4096) from a ptr-matrix into a col
Turning A28673:IV32768 (256x4096) from a ptr-matrix into a col
Turning A32769:IV36864 (256x4096) from a ptr-matrix into a col
Turning A36865:IV40960 (256x4096) from a ptr-matrix into a col
Turning A40961:IV45056 (256x4096) from a ptr-matrix into a col
Turning A45057:IV49152 (256x4096) from a ptr-matrix into a col
Turning A49153:IV53248 (256x4096) from a ptr-matrix into a col
Turning A53249:IV57344 (256x4096) from a ptr-matrix into a col
Turning A57345:IV61440 (256x4096) from a ptr-matrix into a col
Turning A61441:IV65536 (256x4096) from a ptr-matrix into a col

** (/home/welinder/gnome-src/gnumeric/src/.libs/lt-gnumeric:21288): WARNING **: Style optimizer position conflict at J25!
Comment 2 Morten Welinder 2009-06-09 02:26:49 UTC
The style optimizer is not at fault -- it just makes things visible.

There is one problem in sheet_style_find:  gnm_style_link_sheet can change
the style (in the gnm_style_equal sense).  I think we need an extra check
to avoid overwriting an element in the hash:

	res = g_hash_table_lookup (sheet->style_data->style_hash, s);
	if (res != NULL) {
		gnm_style_link (res);
		gnm_style_unlink (s);
		return res;
	}

Adding this will ensure that only new styles are added to the hash.

Fixing this and also turning the style optimizer off, we then get the
warnings from the initial reports:

    WARNING **: Can't find style 0xa060578 for cell GT!C3

(except that a fix in plugins/excel now makes it print the actual cell
address even when there is not cell).
Comment 3 Morten Welinder 2009-06-09 13:10:18 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.