After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 585115 - Use accessor functions instead direct access
Use accessor functions instead direct access
Status: RESOLVED FIXED
Product: yelp
Classification: Applications
Component: General
git master
Other Linux
: Normal trivial
: Yelp 3.0
Assigned To: Yelp maintainers
Yelp maintainers
Depends on:
Blocks: 585391
 
 
Reported: 2009-06-08 06:25 UTC by Javier Jardón (IRC: jjardon)
Modified: 2009-12-09 04:22 UTC
See Also:
GNOME target: ---
GNOME version: 2.27/2.28

Attachments
Use accessor functions instead direct access (4.28 KB, patch)
2009-06-08 06:31 UTC, Javier Jardón (IRC: jjardon) 		none Details | Review
Use accessor functions instead direct access (4.72 KB, patch)
2009-06-08 06:40 UTC, Javier Jardón (IRC: jjardon) 		none Details | Review
Use accessor functions instead direct access (5.00 KB, patch)
2009-08-31 04:11 UTC, Javier Jardón (IRC: jjardon) 		committed Details | Review

Description Javier Jardón (IRC: jjardon) 2009-06-08 06:25:19 UTC 
See http://live.gnome.org/GnomeGoals/UseGseal for more details
Comment 1 Javier Jardón (IRC: jjardon) 2009-06-08 06:31:42 UTC 
Created attachment 136123 [details] [review]
Use accessor functions instead direct access

Is a partial patch because there is not accesor functions for GtkObject flags. See bug #562937
Comment 2 Javier Jardón (IRC: jjardon) 2009-06-08 06:40:33 UTC 
Created attachment 136124 [details] [review]
Use accessor functions instead direct access

Sorry, I forgot update configure.in to bump gtk+ to 2.14
Comment 3 Javier Jardón (IRC: jjardon) 2009-08-31 04:11:57 UTC 
Created attachment 142096 [details] [review]
Use accessor functions instead direct access

With this patch, yelp compiles with -DGSEAL_ENABLED without problems if you have GTK+ version >= 2.17.5

I bump the GTK+ version required to 2.14, but I can do a patch with GTK_CHECK_VERSION (2,14,0) if you prefer.

Regards
Comment 4 Shaun McCance 2009-12-09 03:28:56 UTC 
Thanks, this looks good.  We've had a stable GTK+ release since you first put the patch up.  Let's just make that a hard dependency.  Please bump the GTK+ dep to 2.18.0 and drop the #ifdef stuff, then put push to master.
Comment 5 Javier Jardón (IRC: jjardon) 2009-12-09 04:21:51 UTC 
Comment on attachment 142096 [details] [review]
Use accessor functions instead direct access

committed with the changes you requested

commit 5c43a73ccaeca8ec6c8a7187c279f1e0501168c9
Comment 6 Javier Jardón (IRC: jjardon) 2009-12-09 04:22:08 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.