And I suppose I should have said webOS, not Palm Pre.

Created attachment 136257 [details] [review]
Adds support for the Palm Pre

I've attached my patch, mostly based on the support for the G1.

This is my first contribution to Banshee, so if there's anything else I can do to help this go through, please let me know. :)

Hi Jeff, thanks for the patch, looks pretty good.

1) minor whitespace/indentation inconsistency in the .addins.xml changes

2) Are the audio_folders and playback_mime_types 100% complete/accurate, or do they need more research/changes?  It really does have AmazonMP3 support, for instance?

3) Should probably add yourself to the Copyright/Authors list for WebOSDevice.cs

Thanks for the feedback.

1) Oh, I see the trailing whitespace on the first line. Is that the only problem?

2) The audio_folders are set to what I believe is reasonable. The ringtones and AmazonMP3 folders exist on the system by default (and are used by the Amazon app and the phone app, respectively), but I have arbitrarily chosen the Music and Videos directories.

I do need to verify the playback_mime_types; I haven't yet checked these.

3) I'll include this in an updated patch.

Re 1) I don't know what I was referring to, so ignore that. :)

Created attachment 137753 [details] [review]
Add support for Palm Pre

I've updated the above patch, per your suggestions.

Note that the supported audio/video formats comes from the file format file that, in JSON, matches mimetypes and file extensions to their respective apps. The file is /usr/palm/command-resource-handlers.json, and this is only accessible via the leaked ROM. I'm not sure whether this matters at all . . .

Is there anything further I need to do before this can be applied?

I'm hoping it gets applied sooner than later, so that conflicts do not arise. :)

Why do you have

amazon_base_dir = System.IO.Path.Combine (Source.Volume.MountPoint, audio_folders[1]);

but audio_folders[1] is "Videos/"?  Do you mean to use audio_folders[3]?

Please update the copyright header too, adding yourself.

Also, would you factor out the AmazonMp3GroupSource so it's not duplicated?

Created attachment 138165 [details] [review]
Add support for webOS devices

I hope this takes care of the issues you've mentioned. If the formatting of the copyright is not correct, please correct it to your preferred format. (There is no suggested style in the style guide.)

Thanks Jeff, I slightly modified the copyright lines (putting them on their own lines, putting yours as 2009).  Committed!

Wonderful! Thank you very much. :)

I didn't include it because I'm a crappy artist, but if somebody wants to make an icon like the G1 icon, the support for the two phones would be just about equal.